context.addHitRegion() is not working when using transform operation.

context.addHitRegion() is not working when using transform operation.

Should be able to add hit region when using transform operation.
context.isClipMode uses SkClipStack::getSaveCount() internally.
But the count is incremented by transform operation as well as clip operation.
So, remove the method and then add a new method which is determined by only clip operation.

BUG=389862
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177483

[zino, 2014-06-28 15:17:20]

Please take a look.

[Justin Novosad, 2014-07-02 15:12:32]

https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right):

https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
Source/core/html/canvas/CanvasRenderingContext2D.cpp:378: --m_clipCount;
I don't think this is correct. There could be multiple clips on the same state
stack level.  There could also be 0 clips (this clip may come from a higher a
higher state stack level).
In order to restore properly, I think you need to save the the clipCount in the
state stack rather than in CanvasRenderingContext2D.

https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
File Source/core/html/canvas/CanvasRenderingContext2D.h (right):

https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
Source/core/html/canvas/CanvasRenderingContext2D.h:345: bool isClipMode() {
return m_clipCount; }
should be hasClip()

[zino, 2014-07-03 12:01:29]

On 2014/07/02 15:12:32, junov wrote:
>
https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
> File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right):
> 
>
https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
> Source/core/html/canvas/CanvasRenderingContext2D.cpp:378: --m_clipCount;
> I don't think this is correct. There could be multiple clips on the same state
> stack level.  There could also be 0 clips (this clip may come from a higher a
> higher state stack level).
> In order to restore properly, I think you need to save the the clipCount in
the
> state stack rather than in CanvasRenderingContext2D.
> 
>
https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
> File Source/core/html/canvas/CanvasRenderingContext2D.h (right):
> 
>
https://codereview.chromium.org/352793006/diff/20001/Source/core/html/canvas/...
> Source/core/html/canvas/CanvasRenderingContext2D.h:345: bool isClipMode() {
> return m_clipCount; }
> should be hasClip()

You're right! Thanks for the tip.
Could you please review again?

[Justin Novosad, 2014-07-03 13:37:48]

Very nice test.

lgtm

[zino, 2014-07-03 14:48:18]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-03 14:49:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/352793006/40001

[commit-bot: I haz the power, 2014-07-03 15:52:10]

Change committed as 177483