Issue 352783003: Remove forward declared NSMenu/NSResponder from ChromeClient.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352783003: Remove forward declared NSMenu/NSResponder from ChromeClient.h (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
Mike West

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove forward declared NSMenu/NSResponder from ChromeClient.h This was added in http://trac.webkit.org/changeset/30740 Neither symbol is used in ChromeClient.h. core/rendering/RenderThemeChromiumMac.h uses NSMenu, but appears to get the declaration/definition from elsewhere, together with a few other NS* symbols. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176923

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	Source/core/page/ChromeClient.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/352783003/1

6 years, 6 months ago (2014-06-25 12:05:45 UTC) #3

Message was sent while issue was closed.

Change committed as 176923