Issue 352763002: Grow heap slower if GC freed many global handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352763002: Grow heap slower if GC freed many global handles. (Closed)

Created:
6 years, 6 months ago by ulan

Modified:
6 years, 6 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Grow heap slower if GC freed many global handles. BUG=263503 LOG=Y R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22003

Patch Set 2 : Set limit before PostGarbageCollectionProcessing too. #

Total comments: 1

Patch Set 3 : Add comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -45 lines)			Patch
M	src/global-handles.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/global-handles.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	src/heap.h	View	1 2	3 chunks	+2 lines, -17 lines	0 comments	Download
M	src/heap.cc	View	1 2	9 chunks	+51 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM https://codereview.chromium.org/352763002/diff/20001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/352763002/diff/20001/src/heap.cc#newcode5051 src/heap.cc:5051: factor = max_factor - Could you please leave ...

6 years, 6 months ago (2014-06-25 09:24:00 UTC) #2

ulan

On 2014/06/25 09:24:00, Hannes Payer wrote: > LGTM > > https://codereview.chromium.org/352763002/diff/20001/src/heap.cc > File src/heap.cc (right): ...

6 years, 6 months ago (2014-06-25 09:34:55 UTC) #3