Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 352643002: Prune some dead code from SkPicture.cpp. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Prune some dead code from SkPicture.cpp. There's no path that makes playback != fPlayback.get() anymore. BUG=skia: Committed: https://skia.googlesource.com/skia/+/40684ba95f8b99e3e690efe2cc857251a5f4ad6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/core/SkPicture.cpp View 2 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 6 months ago (2014-06-24 16:48:59 UTC) #1
robertphillips
lgtm
6 years, 6 months ago (2014-06-24 16:56:33 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-24 16:57:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/352643002/1
6 years, 6 months ago (2014-06-24 16:57:45 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 17:12:49 UTC) #5
Message was sent while issue was closed.
Change committed as 40684ba95f8b99e3e690efe2cc857251a5f4ad6b

Powered by Google App Engine
This is Rietveld 408576698