Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: chrome/browser/history/top_sites_impl.cc

Issue 352623002: Port History::QueryMostVisitedURLs to use CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/top_sites_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/top_sites_impl.cc
diff --git a/chrome/browser/history/top_sites_impl.cc b/chrome/browser/history/top_sites_impl.cc
index 9224d35952cc1907d66e756f7c0ed6f3b7372897..d1fd053df57c59a336fe0995a1d102431ddc496e 100644
--- a/chrome/browser/history/top_sites_impl.cc
+++ b/chrome/browser/history/top_sites_impl.cc
@@ -456,9 +456,9 @@ CancelableRequestProvider::Handle TopSitesImpl::StartQueryForMostVisited() {
return hs->QueryMostVisitedURLs(
num_results_to_request_from_history(),
kDaysOfHistory,
- &history_consumer_,
base::Bind(&TopSitesImpl::OnTopSitesAvailableFromHistory,
- base::Unretained(this)));
+ base::Unretained(this)),
+ &cancelable_task_tracker_);
}
return 0;
}
@@ -930,9 +930,9 @@ void TopSitesImpl::OnGotMostVisitedThumbnails(
}
void TopSitesImpl::OnTopSitesAvailableFromHistory(
- CancelableRequestProvider::Handle handle,
- MostVisitedURLList pages) {
- SetTopSites(pages);
+ const MostVisitedURLList* pages) {
+ DCHECK(pages);
+ SetTopSites(*pages);
}
} // namespace history
« no previous file with comments | « chrome/browser/history/top_sites_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698