Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/browser/history/top_sites_impl.h

Issue 352623002: Port History::QueryMostVisitedURLs to use CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_ 5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_
6 #define CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_ 6 #define CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_
7 7
8 #include <list> 8 #include <list>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 209
210 // Stops and starts timer with a delay of |delta|. 210 // Stops and starts timer with a delay of |delta|.
211 void RestartQueryForTopSitesTimer(base::TimeDelta delta); 211 void RestartQueryForTopSitesTimer(base::TimeDelta delta);
212 212
213 // Callback from TopSites with the top sites/thumbnails. Should be called 213 // Callback from TopSites with the top sites/thumbnails. Should be called
214 // from the UI thread. 214 // from the UI thread.
215 void OnGotMostVisitedThumbnails( 215 void OnGotMostVisitedThumbnails(
216 const scoped_refptr<MostVisitedThumbnails>& thumbnails); 216 const scoped_refptr<MostVisitedThumbnails>& thumbnails);
217 217
218 // Called when history service returns a list of top URLs. 218 // Called when history service returns a list of top URLs.
219 void OnTopSitesAvailableFromHistory(CancelableRequestProvider::Handle handle, 219 void OnTopSitesAvailableFromHistory(const MostVisitedURLList* data);
220 MostVisitedURLList data);
221 220
222 scoped_refptr<TopSitesBackend> backend_; 221 scoped_refptr<TopSitesBackend> backend_;
223 222
224 // The top sites data. 223 // The top sites data.
225 scoped_ptr<TopSitesCache> cache_; 224 scoped_ptr<TopSitesCache> cache_;
226 225
227 // Copy of the top sites data that may be accessed on any thread (assuming 226 // Copy of the top sites data that may be accessed on any thread (assuming
228 // you hold |lock_|). The data in |thread_safe_cache_| has blacklisted and 227 // you hold |lock_|). The data in |thread_safe_cache_| has blacklisted and
229 // pinned urls applied (|cache_| does not). 228 // pinned urls applied (|cache_| does not).
230 scoped_ptr<TopSitesCache> thread_safe_cache_; 229 scoped_ptr<TopSitesCache> thread_safe_cache_;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 266
268 // Are we loaded? 267 // Are we loaded?
269 bool loaded_; 268 bool loaded_;
270 269
271 DISALLOW_COPY_AND_ASSIGN(TopSitesImpl); 270 DISALLOW_COPY_AND_ASSIGN(TopSitesImpl);
272 }; 271 };
273 272
274 } // namespace history 273 } // namespace history
275 274
276 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_ 275 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/history/top_sites_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698