Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/history/history_service.h

Issue 352623002: Port History::QueryMostVisitedURLs to use CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 // to all urls on the same scheme/host/port as |url|. This is only valid for 302 // to all urls on the same scheme/host/port as |url|. This is only valid for
303 // HTTP and HTTPS URLs. 303 // HTTP and HTTPS URLs.
304 Handle GetVisibleVisitCountToHost( 304 Handle GetVisibleVisitCountToHost(
305 const GURL& url, 305 const GURL& url,
306 CancelableRequestConsumerBase* consumer, 306 CancelableRequestConsumerBase* consumer,
307 const GetVisibleVisitCountToHostCallback& callback); 307 const GetVisibleVisitCountToHostCallback& callback);
308 308
309 // Request the |result_count| most visited URLs and the chain of 309 // Request the |result_count| most visited URLs and the chain of
310 // redirects leading to each of these URLs. |days_back| is the 310 // redirects leading to each of these URLs. |days_back| is the
311 // number of days of history to use. Used by TopSites. 311 // number of days of history to use. Used by TopSites.
312 typedef base::Callback<void(Handle, history::MostVisitedURLList)> 312 typedef base::Callback<void(const history::MostVisitedURLList*)>
313 QueryMostVisitedURLsCallback; 313 QueryMostVisitedURLsCallback;
314 314
315 Handle QueryMostVisitedURLs(int result_count, int days_back, 315 base::CancelableTaskTracker::TaskId QueryMostVisitedURLs(
316 CancelableRequestConsumerBase* consumer, 316 int result_count,
317 const QueryMostVisitedURLsCallback& callback); 317 int days_back,
318 const QueryMostVisitedURLsCallback& callback,
319 base::CancelableTaskTracker* tracker);
318 320
319 // Request the |result_count| URLs filtered and sorted based on the |filter|. 321 // Request the |result_count| URLs filtered and sorted based on the |filter|.
320 // If |extended_info| is true, additional data will be provided in the 322 // If |extended_info| is true, additional data will be provided in the
321 // results. Computing this additional data is expensive, likely to become 323 // results. Computing this additional data is expensive, likely to become
322 // more expensive as additional data points are added in future changes, and 324 // more expensive as additional data points are added in future changes, and
323 // not useful in most cases. Set |extended_info| to true only if you 325 // not useful in most cases. Set |extended_info| to true only if you
324 // explicitly require the additional data. 326 // explicitly require the additional data.
325 typedef base::Callback<void(Handle, const history::FilteredURLList&)> 327 typedef base::Callback<void(Handle, const history::FilteredURLList&)>
326 QueryFilteredURLsCallback; 328 QueryFilteredURLsCallback;
327 329
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
998 scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_; 1000 scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_;
999 1001
1000 ObserverList<history::VisitDatabaseObserver> visit_database_observers_; 1002 ObserverList<history::VisitDatabaseObserver> visit_database_observers_;
1001 1003
1002 history::DeleteDirectiveHandler delete_directive_handler_; 1004 history::DeleteDirectiveHandler delete_directive_handler_;
1003 1005
1004 DISALLOW_COPY_AND_ASSIGN(HistoryService); 1006 DISALLOW_COPY_AND_ASSIGN(HistoryService);
1005 }; 1007 };
1006 1008
1007 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 1009 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698