Issue 352603002: Remove the unused Document& argument to the TextTrack constructor

Issue 352603002: Remove the unused Document& argument to the TextTrack constructor (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, fs

CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove the unused Document& argument to the TextTrack constructor R=fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176847

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	Source/core/html/HTMLMediaElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/track/InbandTextTrack.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/html/track/InbandTextTrack.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/track/LoadableTextTrack.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/TextTrack.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/html/track/TextTrack.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTRegion.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/352603002/1

6 years, 6 months ago (2014-06-24 13:59:41 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 6 months ago (2014-06-24 14:35:21 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-24 15:19:03 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21430)

6 years, 6 months ago (2014-06-24 15:19:04 UTC) #7

philipj_slow

6 years, 6 months ago (2014-06-24 15:36:01 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r176847 (presubmit successful).

Expand Messages | Collapse Messages