Issue 352583006: HPACK changes required for specification draft '08

Issue 352583006: HPACK changes required for specification draft '08 (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

HPACK changes required for specification draft '08 * Update the Huffman code and test cases. * Updated static entry 16 to "accept-encoding": "gzip, deflate". * Update various section references in comments. This lands server change 69769491 by jgraettinger. BUG=

Patch Set 1 #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+402 lines, -404 lines)			Patch
M	net/spdy/fuzzing/hpack_fuzz_util_test.cc	View	1 chunk	+2 lines, -1 line	2 comments	Download
M	net/spdy/hpack_constants.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	net/spdy/hpack_constants.cc	View	1 chunk	+256 lines, -256 lines	1 comment	Download
M	net/spdy/hpack_decoder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/hpack_decoder_test.cc	View	11 chunks	+36 lines, -36 lines	0 comments	Download
M	net/spdy/hpack_encoder.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/spdy/hpack_encoder_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/hpack_entry.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	net/spdy/hpack_header_table.h	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	net/spdy/hpack_header_table.cc	View	1 chunk	+61 lines, -61 lines	0 comments	Download
M	net/spdy/hpack_huffman_table_test.cc	View	2 chunks	+13 lines, -14 lines	0 comments	Download
M	net/spdy/hpack_input_stream.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/hpack_input_stream_test.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	net/spdy/hpack_output_stream.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/hpack_string_util.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/352583006/diff/1/net/spdy/fuzzing/hpack_fuzz_util_test.cc File net/spdy/fuzzing/hpack_fuzz_util_test.cc (right): https://codereview.chromium.org/352583006/diff/1/net/spdy/fuzzing/hpack_fuzz_util_test.cc#newcode99 net/spdy/fuzzing/hpack_fuzz_util_test.cc:99: "ff"); out of curiosity, why is this wrapped? ...

6 years, 6 months ago (2014-06-25 23:28:30 UTC) #2

Johnny

6 years, 6 months ago (2014-06-26 16:22:39 UTC) #3

https://codereview.chromium.org/352583006/diff/1/net/spdy/fuzzing/hpack_fuzz_...
File net/spdy/fuzzing/hpack_fuzz_util_test.cc (right):

https://codereview.chromium.org/352583006/diff/1/net/spdy/fuzzing/hpack_fuzz_...
net/spdy/fuzzing/hpack_fuzz_util_test.cc:99: "ff");
On 2014/06/25 23:28:30, Ryan Hamilton wrote:
> out of curiosity, why is this wrapped? 

These examples are copy-pasted out of the spec document. I was already mostly
preserving their line wrapping (at 16 bytes), so opted to make it consistent
throughout.

Expand Messages | Collapse Messages