Issue 352583005: Sync 'git cl presubmit' and 'tools/presubmit.py'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352583005: Sync 'git cl presubmit' and 'tools/presubmit.py' (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow

Modified:
6 years, 6 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Sync 'git cl presubmit' and 'tools/presubmit.py' More precisely, add CheckGeneratedRuntimeTests to checks performed by 'git cl presubmit'. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21970

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

6 years, 6 months ago (2014-06-24 13:57:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21970 (presubmit successful).