Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 352583004: Temporary disable ActivityLogApiTest.TriggerEvent to allow refactoring (Closed)

Created:
6 years, 6 months ago by pmarch
Modified:
6 years, 6 months ago
Reviewers:
mvrable
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Temporary disable ActivityLogApiTest.TriggerEvent to allow refactoring of Activity Logger in Blink. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279465

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pmarch
Hi Michael A tiny CL for review. Thanks
6 years, 6 months ago (2014-06-24 10:49:53 UTC) #1
mvrable
lgtm One comment: if you have a bug number for the refactoring work you should ...
6 years, 6 months ago (2014-06-24 16:09:25 UTC) #2
pmarch
On 2014/06/24 16:09:25, mvrable wrote: > lgtm > > One comment: if you have a ...
6 years, 6 months ago (2014-06-24 16:24:18 UTC) #3
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 6 months ago (2014-06-24 16:26:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/352583004/40001
6 years, 6 months ago (2014-06-24 16:27:10 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 19:31:55 UTC) #6
Message was sent while issue was closed.
Change committed as 279465

Powered by Google App Engine
This is Rietveld 408576698