chrome/browser/extensions/api/debugger/debugger_api_constants.cc - Issue 352523003: Have the Debugger extension api check that it has access to the tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api_constants.cc

Issue 352523003: Have the Debugger extension api check that it has access to the tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add PermissionsData::UrlIsRestricted() Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/debugger/debugger_api.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_api_constants.h ('k') | chrome/browser/extensions/api/debugger/debugger_apitest.cc » ('j') | extensions/common/permissions/permissions_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_api_constants.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api_constants.cc b/chrome/browser/extensions/api/debugger/debugger_api_constants.cc

index 70da45ba8805561040e6477f183600b5b134f76c..7ddcd82d6f3b7c40fd8945a2c2841791edaf496b 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api_constants.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api_constants.cc

@@ -8,8 +8,6 @@ namespace debugger_api_constants {

const char kAlreadyAttachedError[] =

"Another debugger is already attached to the * with id: *.";

-const char kAttachToWebUIError[] =

- "Can not attach to the page with the \"*://\" scheme.";

const char kNoTargetError[] = "No * with given id *.";

const char kInvalidTargetError[] =

"Either tab id or extension id must be specified.";