LayoutTests/http/tests/serviceworker/registration-end-to-end.html - Issue 352423005: Add ServiceWorker InstallPhaseEvent.waitUntil() layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

Issue 352423005: Add ServiceWorker InstallPhaseEvent.waitUntil() layout test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add FIXME Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/ready-controlled-document.html ('k') | LayoutTests/http/tests/serviceworker/registration-events.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/registration-end-to-end.html

diff --git a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

index 94dd3bc09c851db9fa032df74d7b0f825e9f016c..212b2decc19b318e24d9d3b7ab0b4649fa253a54 100644

--- a/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

+++ b/LayoutTests/http/tests/serviceworker/registration-end-to-end.html

@@ -60,7 +60,7 @@ t.step(function() {

case 'activating':

assert_equals(lastServiceWorkerState, 'installed');

break;

- case 'active':

+ case 'activated':

assert_equals(lastServiceWorkerState, 'activating');

break;

default:

@@ -68,14 +68,14 @@ t.step(function() {

}

lastServiceWorkerState = sw.state;

- if (sw.state === 'active')

+ if (sw.state === 'activated')

resolve();

});

}));

Promise.all([sawMessage, sawActive]).then(t.step_func(function() {

assert_array_equals(serviceWorkerStates,

- ['parsed', 'installing', 'installed', 'activating', 'active'],

+ ['parsed', 'installing', 'installed', 'activating', 'activated'],

'Service worker should pass through four states');

assert_equals(currentChangeCount, 0,