Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 352403002: Repair the CWND reduction caused by spurious RTO's in QUIC's congestion (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Project:
chromium
Visibility:
Public.

Description

Repair the CWND reduction caused by spurious RTO's in QUIC's congestion control. Merge internal change: 70033195 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -20 lines) Patch
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 1 chunk +19 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 3 chunks +23 lines, -2 lines 0 comments Download
M net/quic/quic_connection_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +25 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-06-26 19:59:16 UTC) #1
Ryan Hamilton
lgtm
6 years, 5 months ago (2014-06-27 14:29:41 UTC) #2
ramant (doing other things)
6 years, 5 months ago (2014-06-27 14:39:10 UTC) #3 
On 2014/06/27 14:29:41, Ryan Hamilton wrote:
> lgtm

Many many thanks Ryan for your very prompt code reviews. Sincerely appreciating
it.

Powered by Google App Engine
This is Rietveld 408576698