Rename ChromeThread to BrowserThread Part 2:

Rename ChromeThread to BrowserThread Part 2:

- Rename the entries under appcache, autocomplete and automation.

BUG=56926
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61610

[willchan no longer on Chromium, 2010-10-05 14:31:39]

LGTM

I forgot to mention another step that would be useful: move chrome_thread.h to
browser_thread.h and leave a stub file in chrome_thread.h that just includes
browser_thread.h.  While you're making these changes in these files, you should
updates the includes to point to browser_thread.h instead of chrome_thread.h. 
Then eventually we can delete chrome_thread.h.

[tfarina, 2010-10-06 14:25:42]

On 2010/10/05 14:31:39, willchan wrote:
> LGTM
> 
> I forgot to mention another step that would be useful: move chrome_thread.h to
> browser_thread.h and leave a stub file in chrome_thread.h that just includes
> browser_thread.h.  While you're making these changes in these files, you
should
> updates the includes to point to browser_thread.h instead of chrome_thread.h. 
> Then eventually we can delete chrome_thread.h.

I got a bunch of: error: ‘ChromeThread’ has not been declared when trying to do
this.

In the chrome_thread.h I just leaved the include to browser_thread.h
and in the chrome_thread.h the code per se.

Maybe I'm doing something wrong?

http://codereview.chromium.org/3581014/diff/1/5

[willchan no longer on Chromium, 2010-10-06 17:08:59]

On 2010/10/06 14:25:42, tfarina wrote:
> On 2010/10/05 14:31:39, willchan wrote:
> > LGTM
> > 
> > I forgot to mention another step that would be useful: move chrome_thread.h
to
> > browser_thread.h and leave a stub file in chrome_thread.h that just includes
> > browser_thread.h.  While you're making these changes in these files, you
> should
> > updates the includes to point to browser_thread.h instead of
chrome_thread.h. 
> > Then eventually we can delete chrome_thread.h.
> 
> I got a bunch of: error: ‘ChromeThread’ has not been declared when trying to
do
> this.
> 
> In the chrome_thread.h I just leaved the include to browser_thread.h
> and in the chrome_thread.h the code per se.
> 
> Maybe I'm doing something wrong?
> 
> http://codereview.chromium.org/3581014/diff/1/5

I dunno.  It looks fine to me =/

[tfarina, 2010-10-06 17:21:37]

On 2010/10/06 17:08:59, willchan wrote:
> On 2010/10/06 14:25:42, tfarina wrote:
> > On 2010/10/05 14:31:39, willchan wrote:
> > > LGTM
> > > 
> > > I forgot to mention another step that would be useful: move
chrome_thread.h
> to
> > > browser_thread.h and leave a stub file in chrome_thread.h that just
includes
> > > browser_thread.h.  While you're making these changes in these files, you
> > should
> > > updates the includes to point to browser_thread.h instead of
> chrome_thread.h. 
> > > Then eventually we can delete chrome_thread.h.
> > 
> > I got a bunch of: error: ‘ChromeThread’ has not been declared when trying to
> do
> > this.
> > 
> > In the chrome_thread.h I just leaved the include to browser_thread.h
> > and in the chrome_thread.h the code per se.
> > 
> > Maybe I'm doing something wrong?
> > 
> > http://codereview.chromium.org/3581014/diff/1/5
> 
> I dunno.  It looks fine to me =/

Right url: http://codereview.chromium.org/3581014