chrome/browser/download/chrome_download_manager_delegate.cc - Issue 352393002: Be explicit about target type in platform_util::OpenItem()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Catch up with changes to JSONStringValueSerializer and address CrOS comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/chrome_download_manager_delegate.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc

index 52a151b2113101f4df368a6c3672262c05994b44..ad2b94bae06ffdf92b88e06ffa60c1fb22c050a5 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate.cc

@@ -433,7 +433,8 @@ void ChromeDownloadManagerDelegate::OpenDownloadUsingPlatformHandler(

base::FilePath platform_path(

GetPlatformDownloadPath(profile_, download, PLATFORM_TARGET_PATH));

DCHECK(!platform_path.empty());

- platform_util::OpenItem(profile_, platform_path);

+ platform_util::OpenItem(profile_, platform_path, platform_util::OPEN_FILE,

+ platform_util::OpenOperationCallback());

}

void ChromeDownloadManagerDelegate::OpenDownload(DownloadItem* download) {