chrome/browser/ui/webui/downloads_dom_handler.cc - Issue 352393002: Be explicit about target type in platform_util::OpenItem()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Chdir on Linux, Fix memory leak in test and address Mac comment. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/downloads_dom_handler.cc

diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc

index 83c753e117528f88fbe891c6801d22dc592253f5..3a3df0396f850f1e00c830b65f50fe81a2d0da8c 100644

--- a/chrome/browser/ui/webui/downloads_dom_handler.cc

+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc

@@ -560,9 +560,10 @@ void DownloadsDOMHandler::HandleOpenDownloadsFolder(

CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_OPEN_FOLDER);

content::DownloadManager* manager = main_notifier_.GetManager();

if (manager) {

- platform_util::OpenItem(

+ platform_util::OpenFolder(

Profile::FromBrowserContext(manager->GetBrowserContext()),

- DownloadPrefs::FromDownloadManager(manager)->DownloadPath());

+ DownloadPrefs::FromDownloadManager(manager)->DownloadPath(),

+ platform_util::OpenOperationCallback());

}