chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 352393002: Be explicit about target type in platform_util::OpenItem()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Chdir on Linux, Fix memory leak in test and address Mac comment. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index ae841dcf5c0e2acbdc5f5e65dc90c3ee02b2094a..255789fbaa29a2e129762e0e7626e4a7acdd0033 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -1330,9 +1330,9 @@ bool DownloadsShowDefaultFolderFunction::RunAsync() {

DownloadManager* manager = NULL;

DownloadManager* incognito_manager = NULL;

GetManagers(GetProfile(), include_incognito(), &manager, &incognito_manager);

- platform_util::OpenItem(

- GetProfile(),

- DownloadPrefs::FromDownloadManager(manager)->DownloadPath());

+ platform_util::OpenFolder(

+ GetProfile(), DownloadPrefs::FromDownloadManager(manager)->DownloadPath(),

+ platform_util::OpenOperationCallback());

RecordApiFunctions(DOWNLOADS_FUNCTION_SHOW_DEFAULT_FOLDER);

return true;

}