Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3063)

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting and initializer refactor Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/platform_util_chromeos.cc
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc
index aad0b73602f9396699b2ae1b17ebdf69b738a162..a2c78160fa5a4963476c0106fc59fe9d62fb2d6c 100644
--- a/chrome/browser/platform_util_chromeos.cc
+++ b/chrome/browser/platform_util_chromeos.cc
@@ -25,9 +25,14 @@ void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
file_manager::util::ShowItemInFolder(profile, full_path);
}
-void OpenItem(Profile* profile, const base::FilePath& full_path) {
+void OpenFile(Profile* profile, const base::FilePath& full_path) {
James Hawkins 2014/09/29 21:09:14 The documentation says |full_path| must poing to a
asanka 2014/09/30 23:07:46 I updated the documentation to not require callers
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- file_manager::util::OpenItem(profile, full_path);
+ file_manager::util::OpenFile(profile, full_path);
+}
+
+void OpenFolder(Profile* profile, const base::FilePath& full_path) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ file_manager::util::OpenFolder(profile, full_path);
}
void OpenExternal(Profile* profile, const GURL& url) {

Powered by Google App Engine
This is Rietveld 408576698