Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/chromeos/file_manager/open_util.h

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/open_util.h
diff --git a/chrome/browser/chromeos/file_manager/open_util.h b/chrome/browser/chromeos/file_manager/open_util.h
index c2c1faa0fd8fc9788b249ad57ac787cb9edc63d9..b6a3561754e97b270228c853e2f6c53652ca7534 100644
--- a/chrome/browser/chromeos/file_manager/open_util.h
+++ b/chrome/browser/chromeos/file_manager/open_util.h
@@ -22,12 +22,13 @@ namespace util {
// If there is another file manager instance open, this call does nothing.
void OpenRemovableDrive(Profile* profile, const base::FilePath& file_path);
-// Opens an item (file or directory). If the target is a directory, the
-// directory will be opened in the file manager. If the target is a file, the
-// file will be opened using a file handler, a file browser handler, or the
-// browser (open in a tab). The default handler has precedence over other
-// handlers, if defined for the type of the target file.
-void OpenItem(Profile* profile, const base::FilePath& file_path);
+// Opens a file using a file handler, a file browser handler, or the browser
+// (open in a tab). The default handler has precedence over other handlers, if
+// defined for the type of the target file.
+void OpenFile(Profile* profile, const base::FilePath& file_path);
+
+// Open a directory in the file manager.
hashimoto 2014/09/26 06:12:44 nit: "Opens a folder"
asanka 2014/09/26 19:35:41 Done.
+void OpenFolder(Profile* profile, const base::FilePath& file_path);
// Opens the file manager for the folder containing the item specified by
// |file_path|, with the item selected.
« no previous file with comments | « no previous file | chrome/browser/chromeos/file_manager/open_util.cc » ('j') | chrome/browser/chromeos/file_manager/open_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698