Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: chrome/browser/platform_util_android.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Catch up with changes to JSONStringValueSerializer and address CrOS comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/platform_util.cc ('k') | chrome/browser/platform_util_chromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "chrome/browser/platform_util.h" 6 #include "chrome/browser/platform_util.h"
7 #include "ui/android/view_android.h" 7 #include "ui/android/view_android.h"
8 8
9 namespace platform_util { 9 namespace platform_util {
10 10
11 // TODO: crbug/115682 to track implementation of the following methods. 11 // TODO: crbug/115682 to track implementation of the following methods.
12 12
13 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) { 13 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
14 NOTIMPLEMENTED(); 14 NOTIMPLEMENTED();
15 } 15 }
16 16
17 void OpenItem(Profile* profile, const base::FilePath& full_path) { 17 void OpenItem(Profile* profile,
18 const base::FilePath& full_path,
19 OpenItemType item_type,
20 const OpenOperationCallback& callback) {
18 NOTIMPLEMENTED(); 21 NOTIMPLEMENTED();
19 } 22 }
20 23
21 void OpenExternal(Profile* profile, const GURL& url) { 24 void OpenExternal(Profile* profile, const GURL& url) {
22 NOTIMPLEMENTED(); 25 NOTIMPLEMENTED();
23 } 26 }
24 27
25 gfx::NativeWindow GetTopLevel(gfx::NativeView view) { 28 gfx::NativeWindow GetTopLevel(gfx::NativeView view) {
26 NOTIMPLEMENTED(); 29 NOTIMPLEMENTED();
27 return view->GetWindowAndroid(); 30 return view->GetWindowAndroid();
(...skipping 12 matching lines...) Expand all
40 void ActivateWindow(gfx::NativeWindow window) { 43 void ActivateWindow(gfx::NativeWindow window) {
41 NOTIMPLEMENTED(); 44 NOTIMPLEMENTED();
42 } 45 }
43 46
44 bool IsVisible(gfx::NativeView view) { 47 bool IsVisible(gfx::NativeView view) {
45 NOTIMPLEMENTED(); 48 NOTIMPLEMENTED();
46 return true; 49 return true;
47 } 50 }
48 51
49 } // namespace platform_util 52 } // namespace platform_util
OLDNEW
« no previous file with comments | « chrome/browser/platform_util.cc ('k') | chrome/browser/platform_util_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698