Be explicit about target type in platform_util::OpenItem()

chrome/browser/chromeos/file_manager/fileapi_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/fileapi_util.h"
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/app_id.h"
@@ skipping 211 matching lines @@
     scoped_refptr<storage::FileSystemContext> file_system_context,
     const GURL& url,
     const storage::FileSystemOperationRunner::StatusCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   storage::FileSystemURL file_system_url = file_system_context->CrackURL(url);
   file_system_context->operation_runner()->DirectoryExists(
       file_system_url, callback);
 }
 
+// Used by GetMetadataForPath
+void GetMetadataOnIOThread(
+    scoped_refptr<storage::FileSystemContext> file_system_context,
+    const GURL& url,
+    const storage::FileSystemOperationRunner::GetMetadataCallback& callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  storage::FileSystemURL file_system_url = file_system_context->CrackURL(url);

[mtomasz, 2015/03/06 07:05:49]

nit: Can be const.

[asanka, 2015/03/06 21:09:40]

Done.

+  file_system_context->operation_runner()->GetMetadata(file_system_url,
+                                                       callback);
+}
+
 // Checks if the |file_path| points non-native location or not.
 bool IsUnderNonNativeLocalPath(const storage::FileSystemContext& context,
                                const base::FilePath& file_path) {
   base::FilePath virtual_path;
   if (!context.external_backend()->GetVirtualPath(file_path, &virtual_path))
     return false;
 
   const storage::FileSystemURL url = context.CreateCrackedFileSystemURL(
       GURL(), storage::kFileSystemTypeExternal, virtual_path);
   if (!url.is_valid())
@@ skipping 308 matching lines @@
 
   // Check the existence of directory using file system API implementation on
   // behalf of the file manager app. We need to grant access beforehand.
   storage::ExternalFileSystemBackend* backend =
       file_system_context->external_backend();
   DCHECK(backend);
   backend->GrantFullAccessToExtension(kFileManagerAppId);
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
-      base::Bind(&CheckIfDirectoryExistsOnIOThread,
-                 file_system_context,
-                 url,
+      base::Bind(&CheckIfDirectoryExistsOnIOThread, file_system_context, url,
                  google_apis::CreateRelayCallback(callback)));
 }
 
+void GetMetadataForPath(
+    scoped_refptr<storage::FileSystemContext> file_system_context,
+    const GURL& url,
+    const storage::FileSystemOperationRunner::GetMetadataCallback& callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  storage::ExternalFileSystemBackend* backend =

[mtomasz, 2015/03/06 07:05:49]

nit: Can be const.

[asanka, 2015/03/06 21:09:40]

The GrantFullAccessToExtension() call requires |backend| not be const.

[mtomasz, 2015/03/07 00:01:12]

I meant:
storage::ExternalFileSystemBackend* const backend = ...

[asanka, 2015/03/07 00:37:00]

Ah. Got it and done.

+      file_system_context->external_backend();
+  DCHECK(backend);
+  backend->GrantFullAccessToExtension(kFileManagerAppId);
+
+  BrowserThread::PostTask(
+      BrowserThread::IO, FROM_HERE,
+      base::Bind(&GetMetadataOnIOThread, file_system_context, url,
+                 google_apis::CreateRelayCallback(callback)));
+}
+
 storage::FileSystemURL CreateIsolatedURLFromVirtualPath(
     const storage::FileSystemContext& context,
     const GURL& origin,
     const base::FilePath& virtual_path) {
   const storage::FileSystemURL original_url =
       context.CreateCrackedFileSystemURL(
           origin, storage::kFileSystemTypeExternal, virtual_path);
 
   std::string register_name;
   const std::string isolated_file_system_id =
       storage::IsolatedContext::GetInstance()->RegisterFileSystemForPath(
           original_url.type(),
           original_url.filesystem_id(),
           original_url.path(),
           &register_name);
   const storage::FileSystemURL isolated_url =
       context.CreateCrackedFileSystemURL(
           origin,
           storage::kFileSystemTypeIsolated,
           base::FilePath(isolated_file_system_id).Append(register_name));
   return isolated_url;
 }
 
 }  // namespace util
 }  // namespace file_manager