Be explicit about target type in platform_util::OpenItem()

chrome/browser/platform_util_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/process/kill.h"
 #include "base/process/launch.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/platform_util_internal.h"
 #include "content/public/browser/browser_thread.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
+namespace platform_util {
+
 namespace {
 
 void XDGUtil(const std::string& util, const std::string& arg) {
   std::vector<std::string> argv;
   argv.push_back(util);
   argv.push_back(arg);
 
   base::LaunchOptions options;
   options.allow_new_privs = true;
   // xdg-open can fall back on mailcap which eventually might plumb through
@@ skipping 16 matching lines @@
 }
 
 void XDGOpen(const std::string& path) {
   XDGUtil("xdg-open", path);
 }
 
 void XDGEmail(const std::string& email) {
   XDGUtil("xdg-email", email);
 }
 
-// TODO(estade): It would be nice to be able to select the file in the file
-// manager, but that probably requires extending xdg-open. For now just
-// show the folder.
-void ShowItemInFolderOnFileThread(const base::FilePath& full_path) {
-  base::FilePath dir = full_path.DirName();
-  if (!base::DirectoryExists(dir))
-    return;
-
-  XDGOpen(dir.value());
-}
-
 }  // namespace
 
-namespace platform_util {
+namespace internal {
+
+void PlatformOpenVerifiedItem(const base::FilePath& path, OpenItemType) {
+  XDGOpen(path.value());

[rickyz (no longer on Chrome), 2015/02/04 23:19:30]

Now that https://codereview.chromium.org/885423003/ has landed, you can
specialize this for directories by setting current_directory in LaunchOptions
and running xdg-open .

This avoids any possibility of TOCTOU issues where a somebody can race the
checks by replacing a directory with a file.

[asanka, 2015/02/05 18:07:25]

Did so. PTAL?

+}
+}
 
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
-      base::Bind(&ShowItemInFolderOnFileThread, full_path));
-}
-
-void OpenItem(Profile* profile, const base::FilePath& full_path) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
-      base::Bind(&XDGOpen, full_path.value()));
+  // TODO(estade): It would be nice to be able to select the file in the file
+  // manager, but that probably requires extending xdg-open. For now just show
+  // the folder.
+  OpenFolder(profile, full_path.DirName(), OpenOperationCallback());
 }
 
 void OpenExternal(Profile* profile, const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (url.SchemeIs("mailto"))
     XDGEmail(url.spec());
   else
     XDGOpen(url.spec());
 }
 
 }  // namespace platform_util