Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Side by Side Diff: chrome/browser/platform_util_android.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting and initializer refactor Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "chrome/browser/platform_util.h" 6 #include "chrome/browser/platform_util.h"
7 #include "ui/base/android/view_android.h" 7 #include "ui/base/android/view_android.h"
8 8
9 namespace platform_util { 9 namespace platform_util {
10 10
11 // TODO: crbug/115682 to track implementation of the following methods. 11 // TODO: crbug/115682 to track implementation of the following methods.
12 12
13 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) { 13 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
14 NOTIMPLEMENTED(); 14 NOTIMPLEMENTED();
15 } 15 }
16 16
17 void OpenItem(Profile* profile, const base::FilePath& full_path) { 17 void OpenFile(Profile* profile, const base::FilePath& full_path) {
18 NOTIMPLEMENTED(); 18 NOTIMPLEMENTED();
19 } 19 }
20 20
21 void OpenFolder(Profile* profile, const base::FilePath& full_path) {
22 NOTIMPLEMENTED();
23 }
24
21 void OpenExternal(Profile* profile, const GURL& url) { 25 void OpenExternal(Profile* profile, const GURL& url) {
22 NOTIMPLEMENTED(); 26 NOTIMPLEMENTED();
23 } 27 }
24 28
25 gfx::NativeWindow GetTopLevel(gfx::NativeView view) { 29 gfx::NativeWindow GetTopLevel(gfx::NativeView view) {
26 NOTIMPLEMENTED(); 30 NOTIMPLEMENTED();
27 return view->GetWindowAndroid(); 31 return view->GetWindowAndroid();
28 } 32 }
29 33
30 gfx::NativeView GetParent(gfx::NativeView view) { 34 gfx::NativeView GetParent(gfx::NativeView view) {
31 NOTIMPLEMENTED(); 35 NOTIMPLEMENTED();
32 return view; 36 return view;
33 } 37 }
34 38
35 bool IsWindowActive(gfx::NativeWindow window) { 39 bool IsWindowActive(gfx::NativeWindow window) {
36 NOTIMPLEMENTED(); 40 NOTIMPLEMENTED();
37 return false; 41 return false;
38 } 42 }
39 43
40 void ActivateWindow(gfx::NativeWindow window) { 44 void ActivateWindow(gfx::NativeWindow window) {
41 NOTIMPLEMENTED(); 45 NOTIMPLEMENTED();
42 } 46 }
43 47
44 bool IsVisible(gfx::NativeView view) { 48 bool IsVisible(gfx::NativeView view) {
45 NOTIMPLEMENTED(); 49 NOTIMPLEMENTED();
46 return true; 50 return true;
47 } 51 }
48 52
49 } // namespace platform_util 53 } // namespace platform_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698