Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media_galleries/media_galleries_scan_result_controller. h" 5 #include "chrome/browser/media_galleries/media_galleries_scan_result_controller. h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <list> 8 #include <list>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 entry->second.selected = selected; 179 entry->second.selected = selected;
180 } 180 }
181 181
182 void MediaGalleriesScanResultController::DidClickOpenFolderViewer( 182 void MediaGalleriesScanResultController::DidClickOpenFolderViewer(
183 MediaGalleryPrefId pref_id) { 183 MediaGalleryPrefId pref_id) {
184 ScanResults::const_iterator entry = scan_results_.find(pref_id); 184 ScanResults::const_iterator entry = scan_results_.find(pref_id);
185 if (entry == scan_results_.end()) { 185 if (entry == scan_results_.end()) {
186 NOTREACHED(); 186 NOTREACHED();
187 return; 187 return;
188 } 188 }
189 platform_util::OpenItem(GetProfile(), entry->second.pref_info.AbsolutePath()); 189 platform_util::OpenFolder(GetProfile(),
190 entry->second.pref_info.AbsolutePath());
190 } 191 }
191 192
192 void MediaGalleriesScanResultController::DidForgetEntry( 193 void MediaGalleriesScanResultController::DidForgetEntry(
193 MediaGalleryPrefId pref_id) { 194 MediaGalleryPrefId pref_id) {
194 media_galleries::UsageCount(media_galleries::ADD_SCAN_RESULTS_FORGET_GALLERY); 195 media_galleries::UsageCount(media_galleries::ADD_SCAN_RESULTS_FORGET_GALLERY);
195 results_to_remove_.insert(pref_id); 196 results_to_remove_.insert(pref_id);
196 scan_results_.erase(pref_id); 197 scan_results_.erase(pref_id);
197 dialog_->UpdateGalleries(); 198 dialog_->UpdateGalleries();
198 } 199 }
199 200
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 MediaGalleriesPreferences* /*prefs*/, 377 MediaGalleriesPreferences* /*prefs*/,
377 MediaGalleryPrefId /*pref_id*/) { 378 MediaGalleryPrefId /*pref_id*/) {
378 OnPreferenceUpdate(extension_->id()); 379 OnPreferenceUpdate(extension_->id());
379 } 380 }
380 381
381 void MediaGalleriesScanResultController::OnGalleryInfoUpdated( 382 void MediaGalleriesScanResultController::OnGalleryInfoUpdated(
382 MediaGalleriesPreferences* /*prefs*/, 383 MediaGalleriesPreferences* /*prefs*/,
383 MediaGalleryPrefId /*pref_id*/) { 384 MediaGalleryPrefId /*pref_id*/) {
384 OnPreferenceUpdate(extension_->id()); 385 OnPreferenceUpdate(extension_->id());
385 } 386 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698