Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 352393002: Be explicit about target type in platform_util::OpenItem() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/downloads/downloads_api.h" 5 #include "chrome/browser/extensions/api/downloads/downloads_api.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 1356 matching lines...) Expand 10 before | Expand all | Expand 10 after
1367 } 1367 }
1368 1368
1369 DownloadsShowDefaultFolderFunction::DownloadsShowDefaultFolderFunction() {} 1369 DownloadsShowDefaultFolderFunction::DownloadsShowDefaultFolderFunction() {}
1370 1370
1371 DownloadsShowDefaultFolderFunction::~DownloadsShowDefaultFolderFunction() {} 1371 DownloadsShowDefaultFolderFunction::~DownloadsShowDefaultFolderFunction() {}
1372 1372
1373 bool DownloadsShowDefaultFolderFunction::RunAsync() { 1373 bool DownloadsShowDefaultFolderFunction::RunAsync() {
1374 DownloadManager* manager = NULL; 1374 DownloadManager* manager = NULL;
1375 DownloadManager* incognito_manager = NULL; 1375 DownloadManager* incognito_manager = NULL;
1376 GetManagers(GetProfile(), include_incognito(), &manager, &incognito_manager); 1376 GetManagers(GetProfile(), include_incognito(), &manager, &incognito_manager);
1377 platform_util::OpenItem( 1377 platform_util::OpenFolder(
1378 GetProfile(), 1378 GetProfile(),
1379 DownloadPrefs::FromDownloadManager(manager)->DownloadPath()); 1379 DownloadPrefs::FromDownloadManager(manager)->DownloadPath());
1380 RecordApiFunctions(DOWNLOADS_FUNCTION_SHOW_DEFAULT_FOLDER); 1380 RecordApiFunctions(DOWNLOADS_FUNCTION_SHOW_DEFAULT_FOLDER);
1381 return true; 1381 return true;
1382 } 1382 }
1383 1383
1384 DownloadsOpenFunction::DownloadsOpenFunction() {} 1384 DownloadsOpenFunction::DownloadsOpenFunction() {}
1385 1385
1386 DownloadsOpenFunction::~DownloadsOpenFunction() {} 1386 DownloadsOpenFunction::~DownloadsOpenFunction() {}
1387 1387
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
1931 const Extension* extension, 1931 const Extension* extension,
1932 UnloadedExtensionInfo::Reason reason) { 1932 UnloadedExtensionInfo::Reason reason) {
1933 DCHECK_CURRENTLY_ON(BrowserThread::UI); 1933 DCHECK_CURRENTLY_ON(BrowserThread::UI);
1934 std::set<const Extension*>::iterator iter = 1934 std::set<const Extension*>::iterator iter =
1935 shelf_disabling_extensions_.find(extension); 1935 shelf_disabling_extensions_.find(extension);
1936 if (iter != shelf_disabling_extensions_.end()) 1936 if (iter != shelf_disabling_extensions_.end())
1937 shelf_disabling_extensions_.erase(iter); 1937 shelf_disabling_extensions_.erase(iter);
1938 } 1938 }
1939 1939
1940 } // namespace extensions 1940 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698