Be explicit about target type in platform_util::OpenItem()

chrome/browser/platform_util_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/process/kill.h"
 #include "base/process/launch.h"
@@ skipping 32 matching lines @@
 }
 
 void XDGOpen(const std::string& path) {
   XDGUtil("xdg-open", path);
 }
 
 void XDGEmail(const std::string& email) {
   XDGUtil("xdg-email", email);
 }
 
-// TODO(estade): It would be nice to be able to select the file in the file
-// manager, but that probably requires extending xdg-open. For now just
-// show the folder.
-void ShowItemInFolderOnFileThread(const base::FilePath& full_path) {
-  base::FilePath dir = full_path.DirName();
-  if (!base::DirectoryExists(dir))
+void OpenFileOnFileThread(const base::FilePath& full_path) {
+  if (!base::PathExists(full_path) || base::DirectoryExists(full_path))
     return;
+  XDGOpen(full_path.value());
+}
 
-  XDGOpen(dir.value());
+void OpenFolderOnFileThread(const base::FilePath& full_path) {
+  if (!base::DirectoryExists(full_path))
+    return;
+  XDGOpen(full_path.value());
 }
 
 }  // namespace
 
 namespace platform_util {
 
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
-      base::Bind(&ShowItemInFolderOnFileThread, full_path));
+  // TODO(estade): It would be nice to be able to select the file in the file
+  // manager, but that probably requires extending xdg-open. For now just show
+  // the folder.
+  BrowserThread::PostTask(
+      BrowserThread::FILE,
+      FROM_HERE,
+      base::Bind(&OpenFolderOnFileThread, full_path.DirName()));
 }
 
-void OpenItem(Profile* profile, const base::FilePath& full_path) {
+void OpenFile(Profile* profile, const base::FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
-      base::Bind(&XDGOpen, full_path.value()));
+  BrowserThread::PostTask(BrowserThread::FILE,
+                          FROM_HERE,
+                          base::Bind(&OpenFileOnFileThread, full_path));
+}
+
+void OpenFolder(Profile* profile, const base::FilePath& full_path) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  BrowserThread::PostTask(BrowserThread::FILE,
+                          FROM_HERE,
+                          base::Bind(&OpenFolderOnFileThread, full_path));
 }
 
 void OpenExternal(Profile* profile, const GURL& url) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (url.SchemeIs("mailto"))
     XDGEmail(url.spec());
   else
     XDGOpen(url.spec());
 }
 
 }  // namespace platform_util