net/spdy/spdy_protocol.h - Issue 352383002: Update SPDY4 settings ID to 16 bits (from 8).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_protocol.h

Issue 352383002: Update SPDY4 settings ID to 16 bits (from 8). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Extract SpdyConstants::GetSettingSize() Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_protocol.h

diff --git a/net/spdy/spdy_protocol.h b/net/spdy/spdy_protocol.h

index c80c0c06f29f9baac4d3c2a428e6d43e0d7ab397..bd6ff0b7bf4542db8410cd36adc63e7ece05f9c6 100644

--- a/net/spdy/spdy_protocol.h

+++ b/net/spdy/spdy_protocol.h

@@ -511,6 +511,9 @@ class NET_EXPORT_PRIVATE SpdyConstants {

// versions <= 3.

static size_t GetSizeOfSizeField(SpdyMajorVersion version);

+ // Returns the size (in bytes) of a wire setting ID and value.

+ static size_t GetSettingSize(SpdyMajorVersion version);

static SpdyMajorVersion ParseMajorVersion(int version_number);

static int SerializeMajorVersion(SpdyMajorVersion version);

« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_protocol.cc » ('j') | no next file with comments »