Issue 352383002: Update SPDY4 settings ID to 16 bits (from 8).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352383002: Update SPDY4 settings ID to 16 bits (from 8). (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update SPDY4 settings ID to 16 bits (from 8). This lands server change 70021377 by jgraettinger. BUG=

Patch Set 2 : Extract SpdyConstants::GetSettingSize() #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -23 lines)			Patch
M	net/spdy/spdy_framer.cc	View	1	5 chunks	+7 lines, -7 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View		4 chunks	+16 lines, -16 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_protocol.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/352383002/diff/1/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/352383002/diff/1/net/spdy/spdy_framer.cc#newcode878 net/spdy/spdy_framer.cc:878: size_t setting_size = (protocol_version() <= SPDY3 ? 8 ...

6 years, 6 months ago (2014-06-26 15:43:20 UTC) #2

Johnny

6 years, 6 months ago (2014-06-26 16:19:08 UTC) #3

https://codereview.chromium.org/352383002/diff/1/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://codereview.chromium.org/352383002/diff/1/net/spdy/spdy_framer.cc#newc...
net/spdy/spdy_framer.cc:878: size_t setting_size = (protocol_version() <= SPDY3
? 8 : 6);
On 2014/06/26 15:43:20, Ryan Hamilton wrote:
> Since this is used in a few places, consider extracting to a method.

Done.

Expand Messages | Collapse Messages

Issue 352383002: Update SPDY4 settings ID to 16 bits (from 8). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Extract SpdyConstants::GetSettingSize() #

Messages