Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 352313003: Make it possible to set the HTTP origin header from content (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make it possible to set the HTTP origin header from content The goal is to eventually have an empty HTTP origin header added if needed in content rather than in FrameFetchContext::addAdditionalRequestHeaders. BUG=376025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -35 lines) Patch
M Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +2 lines, -29 lines 0 comments Download
M Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 2 chunks +27 lines, -0 lines 0 comments Download
M public/platform/WebURLRequest.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
clamy
@japhet, ppi: PTAL
6 years, 6 months ago (2014-06-26 15:38:47 UTC) #1
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-26 15:58:21 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-26 17:36:22 UTC) #3
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-27 09:34:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/352313003/1
6 years, 6 months ago (2014-06-27 09:34:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 10:41:06 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 11:14:41 UTC) #7
Message was sent while issue was closed.
Change committed as 177091

Powered by Google App Engine
This is Rietveld 408576698