Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 352213002: PNaCl dynamic loading: Extend pnacl-translate to be able to translate PSOs (Closed)

Created:
6 years, 6 months ago by Mark Seaborn
Modified:
6 years, 5 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

PNaCl dynamic loading: Extend pnacl-translate to be able to translate PSOs Add a "-pso" option to tell pnacl-translate to treat the input as a PSO and translate it to an ELF DSO. In principle, pnacl-translate could auto-detect the difference between a pexe and a PSO, but that would involve opening the file to check which symbols it defines, which might slow down pnacl-translate unnecessarily. The minimal test for this just checks that the DSO is created successfully. I've also tested this against the PNaCl dynamic loader implementation that I'll add in a follow-on change. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3873 TEST=run_pnacl_dynamic_loading_test R=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13413

Patch Set 1 #

Patch Set 2 : Retry upload #

Patch Set 3 : Retry upload #

Patch Set 4 : Fix #

Patch Set 5 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -7 lines) Patch
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download
M pnacl/build.sh View 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-translate.py View 5 chunks +18 lines, -5 lines 0 comments Download
M site_scons/site_tools/naclsdk.py View 2 chunks +2 lines, -0 lines 0 comments Download
A tests/pnacl_dynamic_loading/nacl.scons View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A tests/pnacl_dynamic_loading/test_pso.c View 1 chunk +26 lines, -0 lines 0 comments Download
M toolchain_build/toolchain_build_pnacl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
6 years, 6 months ago (2014-06-25 23:43:57 UTC) #1
Derek Schuff
lgtm
6 years, 6 months ago (2014-06-26 22:04:07 UTC) #2
Mark Seaborn
6 years, 5 months ago (2014-06-27 15:47:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r13413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698