src/property.h - Issue 3522008: This is a little experiment to move Failure to a superclass above Object...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/property.h

Issue 3522008: This is a little experiment to move Failure to a superclass above Object... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/property.h

===================================================================

--- src/property.h (revision 5559)

+++ src/property.h (working copy)

@@ -46,9 +46,11 @@

}

Object* KeyToSymbol() {

+ Object* result;

+ { TryAllocation t = Heap::LookupSymbol(key_);

+ if (!t->ToObject(&result)) return t;

+ }

if (!StringShape(key_).IsSymbol()) {

- Object* result = Heap::LookupSymbol(key_);

- if (result->IsFailure()) return result;

key_ = String::cast(result);

}

return key_;

« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.cc » ('j') | no next file with comments »