This is a little experiment to move Failure to a superclass above Object...

src/ia32/stub-cache-ia32.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 793 matching lines @@
 }
 
 
 // Generate code to check that a global property cell is empty. Create
 // the property cell at compilation time if no cell exists for the
 // property.
 static Object* GenerateCheckPropertyCell(MacroAssembler* masm,
                                          GlobalObject* global,
                                          String* name,
                                          Register scratch,
+  Object* probe;
+  { TryAllocation t = global->EnsurePropertyCell(name);
+    if (!t->ToObject(&probe)) return t;
+  }
                                          Label* miss) {
-  Object* probe = global->EnsurePropertyCell(name);
-  if (probe->IsFailure()) return probe;
   JSGlobalPropertyCell* cell = JSGlobalPropertyCell::cast(probe);
   ASSERT(cell->value()->IsTheHole());
   __ mov(scratch, Immediate(Handle<Object>(cell)));
   __ cmp(FieldOperand(scratch, JSGlobalPropertyCell::kValueOffset),
          Immediate(Factory::the_hole_value()));
   __ j(not_equal, miss, not_taken);
   return cell;
 }
 
 
@@ skipping 480 matching lines @@
     __ cmp(FieldOperand(edi, JSFunction::kSharedFunctionInfoOffset),
            Immediate(Handle<SharedFunctionInfo>(function->shared())));
     __ j(not_equal, miss, not_taken);
   } else {
     __ cmp(Operand(edi), Immediate(Handle<JSFunction>(function)));
     __ j(not_equal, miss, not_taken);
   }
 }
 
 
+  Object* obj;
+  { TryAllocation t =
+        StubCache::ComputeCallMiss(arguments().immediate(), kind_);
+    if (!t->ToObject(&obj)) return t;
+  }
 Object* CallStubCompiler::GenerateMissBranch() {
-  Object* obj = StubCache::ComputeCallMiss(arguments().immediate(), kind_);
-  if (obj->IsFailure()) return obj;
   __ jmp(Handle<Code>(Code::cast(obj)), RelocInfo::CODE_TARGET);
   return obj;
 }
 
 
 Object* CallStubCompiler::CompileCallField(JSObject* object,
                                            JSObject* holder,
                                            int index,
                                            String* name) {
   // ----------- S t a t e -------------
@@ skipping 31 matching lines @@
   // necessary.
   if (object->IsGlobalObject()) {
     __ mov(edx, FieldOperand(edx, GlobalObject::kGlobalReceiverOffset));
     __ mov(Operand(esp, (argc + 1) * kPointerSize), edx);
   }
 
   // Invoke the function.
   __ InvokeFunction(edi, arguments(), JUMP_FUNCTION);
 
   // Handle call cache miss.
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(FIELD, name);
 }
 
 
 Object* CallStubCompiler::CompileArrayPushCall(Object* object,
                                                JSObject* holder,
                                                JSGlobalPropertyCell* cell,
                                                JSFunction* function,
@@ skipping 123 matching lines @@
       // Elements are in new space, so write barrier is not required.
       __ ret((argc + 1) * kPointerSize);
     }
 
     __ bind(&call_builtin);
     __ TailCallExternalReference(ExternalReference(Builtins::c_ArrayPush),
                                  argc + 1,
                                  1);
   }
 
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 Object* CallStubCompiler::CompileArrayPopCall(Object* object,
                                               JSObject* holder,
                                               JSGlobalPropertyCell* cell,
                                               JSFunction* function,
@@ skipping 58 matching lines @@
 
   __ bind(&return_undefined);
   __ mov(eax, Immediate(Factory::undefined_value()));
   __ ret((argc + 1) * kPointerSize);
 
   __ bind(&call_builtin);
   __ TailCallExternalReference(ExternalReference(Builtins::c_ArrayPop),
                                argc + 1,
                                1);
 
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 Object* CallStubCompiler::CompileStringCharCodeAtCall(
     Object* object,
     JSObject* holder,
     JSGlobalPropertyCell* cell,
@@ skipping 47 matching lines @@
   char_code_at_generator.GenerateFast(masm());
   __ ret((argc + 1) * kPointerSize);
 
   ICRuntimeCallHelper call_helper;
   char_code_at_generator.GenerateSlow(masm(), call_helper);
 
   __ bind(&index_out_of_range);
   __ Set(eax, Immediate(Factory::nan_value()));
   __ ret((argc + 1) * kPointerSize);
 
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 Object* CallStubCompiler::CompileStringCharAtCall(Object* object,
                                                   JSObject* holder,
                                                   JSGlobalPropertyCell* cell,
                                                   JSFunction* function,
@@ skipping 49 matching lines @@
   char_at_generator.GenerateFast(masm());
   __ ret((argc + 1) * kPointerSize);
 
   ICRuntimeCallHelper call_helper;
   char_at_generator.GenerateSlow(masm(), call_helper);
 
   __ bind(&index_out_of_range);
   __ Set(eax, Immediate(Factory::empty_string()));
   __ ret((argc + 1) * kPointerSize);
 
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 Object* CallStubCompiler::CompileStringFromCharCodeCall(
     Object* object,
     JSObject* holder,
     JSGlobalPropertyCell* cell,
@@ skipping 50 matching lines @@
 
   ICRuntimeCallHelper call_helper;
   char_from_code_generator.GenerateSlow(masm(), call_helper);
 
   // Tail call the full function. We do not have to patch the receiver
   // because the function makes no use of it.
   __ bind(&slow);
   __ InvokeFunction(function, arguments(), JUMP_FUNCTION);
 
   __ bind(&miss);
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   // ecx: function name.
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return (cell == NULL) ? GetCode(function) : GetCode(NORMAL, name);
 }
 
 
 Object* CallStubCompiler::CompileMathFloorCall(Object* object,
                                                JSObject* holder,
                                                JSGlobalPropertyCell* cell,
                                                JSFunction* function,
@@ skipping 102 matching lines @@
   __ bind(&already_round);
   __ mov(eax, Operand(esp, 1 * kPointerSize));
   __ ret(2 * kPointerSize);
 
   // Tail call the full function. We do not have to patch the receiver
   // because the function makes no use of it.
   __ bind(&slow);
   __ InvokeFunction(function, arguments(), JUMP_FUNCTION);
 
   __ bind(&miss);
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   // ecx: function name.
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return (cell == NULL) ? GetCode(function) : GetCode(NORMAL, name);
 }
 
 
 Object* CallStubCompiler::CompileMathAbsCall(Object* object,
                                              JSObject* holder,
                                              JSGlobalPropertyCell* cell,
                                              JSFunction* function,
@@ skipping 80 matching lines @@
   __ mov(FieldOperand(eax, HeapNumber::kExponentOffset), ebx);
   __ mov(FieldOperand(eax, HeapNumber::kMantissaOffset), ecx);
   __ ret(2 * kPointerSize);
 
   // Tail call the full function. We do not have to patch the receiver
   // because the function makes no use of it.
   __ bind(&slow);
   __ InvokeFunction(function, arguments(), JUMP_FUNCTION);
 
   __ bind(&miss);
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   // ecx: function name.
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return (cell == NULL) ? GetCode(function) : GetCode(NORMAL, name);
 }
 
 
 Object* CallStubCompiler::CompileCallConstant(Object* object,
                                               JSObject* holder,
                                               JSFunction* function,
                                               String* name,
@@ skipping 130 matching lines @@
     GenerateFastApiCall(masm(), optimization, argc);
   } else {
     __ InvokeFunction(function, arguments(), JUMP_FUNCTION);
   }
 
   // Handle call cache miss.
   __ bind(&miss);
   if (depth != kInvalidProtoDepth) {
     FreeSpaceForFastApiCall(masm(), eax);
   }
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss_in_smi_check);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 Object* CallStubCompiler::CompileCallInterceptor(JSObject* object,
                                                  JSObject* holder,
                                                  String* name) {
   // ----------- S t a t e -------------
@@ skipping 42 matching lines @@
   if (object->IsGlobalObject()) {
     __ mov(edx, FieldOperand(edx, GlobalObject::kGlobalReceiverOffset));
     __ mov(Operand(esp, (argc + 1) * kPointerSize), edx);
   }
 
   // Invoke the function.
   __ mov(edi, eax);
   __ InvokeFunction(edi, arguments(), JUMP_FUNCTION);
 
   // Handle load cache miss.
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ bind(&miss);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(INTERCEPTOR, name);
 }
 
 
 Object* CallStubCompiler::CompileCallGlobal(JSObject* object,
                                             GlobalObject* holder,
                                             JSGlobalPropertyCell* cell,
                                             JSFunction* function,
@@ skipping 38 matching lines @@
   // Jump to the cached code (tail call).
   __ IncrementCounter(&Counters::call_global_inline, 1);
   ASSERT(function->is_compiled());
   Handle<Code> code(function->code());
   ParameterCount expected(function->shared()->formal_parameter_count());
   __ InvokeCode(code, expected, arguments(),
                 RelocInfo::CODE_TARGET, JUMP_FUNCTION);
 
   // Handle call cache miss.
   __ bind(&miss);
+  Object* obj;
+  { TryAllocation t = GenerateMissBranch();
+    if (!t->ToObject(&obj)) return t;
+  }
   __ IncrementCounter(&Counters::call_global_inline_miss, 1);
-  Object* obj = GenerateMissBranch();
-  if (obj->IsFailure()) return obj;
 
   // Return the generated code.
   return GetCode(NORMAL, name);
 }
 
 
 Object* StoreStubCompiler::CompileStoreField(JSObject* object,
                                              int index,
                                              Map* transition,
                                              String* name) {
@@ skipping 731 matching lines @@
   // Return the generated code.
   return GetCode();
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32