Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: src/objects.h

Issue 352173006: Clean up the global object naming madness. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 50499db3edb064e34c9499ea6d45944becd8d2fb..f6258ec832b4bc50b98f1037f4f90c1a55b0117a 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7599,6 +7599,7 @@ class JSFunction: public JSObject {
// [context]: The context for this function.
inline Context* context();
+ inline JSObject* global_proxy();
Igor Sheludko 2014/07/01 08:35:42 Consider moving declaration and definition of this
inline void set_context(Object* context);
// [code]: The generated code object for this function. Executed
@@ -7854,7 +7855,7 @@ class GlobalObject: public JSObject {
DECL_ACCESSORS(global_context, Context)
// [global receiver]: the global receiver object of the context
Igor Sheludko 2014/07/01 08:35:42 Outdated comment.
- DECL_ACCESSORS(global_receiver, JSObject)
+ DECL_ACCESSORS(global_proxy, JSObject)
// Retrieve the property cell used to store a property.
PropertyCell* GetPropertyCell(LookupResult* result);
@@ -7865,8 +7866,8 @@ class GlobalObject: public JSObject {
static const int kBuiltinsOffset = JSObject::kHeaderSize;
static const int kNativeContextOffset = kBuiltinsOffset + kPointerSize;
static const int kGlobalContextOffset = kNativeContextOffset + kPointerSize;
- static const int kGlobalReceiverOffset = kGlobalContextOffset + kPointerSize;
- static const int kHeaderSize = kGlobalReceiverOffset + kPointerSize;
+ static const int kGlobalProxyOffset = kGlobalContextOffset + kPointerSize;
+ static const int kHeaderSize = kGlobalProxyOffset + kPointerSize;
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(GlobalObject);

Powered by Google App Engine
This is Rietveld 408576698