Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 352173005: Become an owner for the various bits of translate that I am now familiar with. (Closed)

Created:
6 years, 5 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Become an owner for the various bits of translate that I am now familiar with. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280752

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments, remove mad@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/translate/OWNERS View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/renderer/translate/OWNERS View 1 1 chunk +6 lines, -1 line 0 comments Download
M components/translate/OWNERS View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrew Hayden (chromium.org)
With a large amount of CLD refactoring completed, I've told Takashi I was willing to ...
6 years, 5 months ago (2014-06-27 16:09:05 UTC) #1
Andrew Hayden (chromium.org)
... and some chromium.org documentation work: https://sites.google.com/a/chromium.org/dev/developers/how-tos/compact-language-detector-cld-data-source-configuration
6 years, 5 months ago (2014-06-27 16:10:13 UTC) #2
MAD
I, indeed, wouldn't mind being removed from the list of OWNERs if others are OK ...
6 years, 5 months ago (2014-06-27 19:51:39 UTC) #3
Takashi Toyoshima
+1 https://codereview.chromium.org/352173005/diff/1/chrome/browser/translate/OWNERS File chrome/browser/translate/OWNERS (right): https://codereview.chromium.org/352173005/diff/1/chrome/browser/translate/OWNERS#newcode1 chrome/browser/translate/OWNERS:1: droger@chromium.org Now translate is a little complicated and ...
6 years, 5 months ago (2014-06-30 02:14:34 UTC) #4
hajimehoshi
+1
6 years, 5 months ago (2014-06-30 02:58:27 UTC) #5
Andrew Hayden (chromium.org)
I've added file comments as requested by Takashi and I've removed mad@ by his request; ...
6 years, 5 months ago (2014-06-30 11:37:57 UTC) #6
droger
lgtm
6 years, 5 months ago (2014-06-30 11:43:15 UTC) #7
Takashi Toyoshima
lgtm
6 years, 5 months ago (2014-07-01 02:47:18 UTC) #8
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 5 months ago (2014-07-01 06:02:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/352173005/20001
6 years, 5 months ago (2014-07-01 06:03:17 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 06:43:29 UTC) #11
Message was sent while issue was closed.
Change committed as 280752

Powered by Google App Engine
This is Rietveld 408576698