Relax object literal checking to follow ES6

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2244 matching lines @@
     "\"foo\": 1, \"foo\": 2",
     "foo: 1, \"foo\": 2",
     "1: 1, 1: 2",
     "1: 1, \"1\": 2",
     "get: 1, get: 2",  // Not a getter for real, just a property called get.
     "set: 1, set: 2",  // Not a setter for real, just a property called set.
     NULL
   };
 
   RunParserSyncTest(non_strict_context_data, statement_data, kSuccess);
-  RunParserSyncTest(strict_context_data, statement_data, kError);
+  RunParserSyncTest(strict_context_data, statement_data, kSuccess);
 }
 
 
-TEST(ErrorsObjectLiteralChecking) {
+TEST(DuplicatePropertyObjectLiteralChecking) {
   const char* context_data[][2] = {
     {"\"use strict\"; var myobject = {", "};"},
     {"var myobject = {", "};"},
     { NULL, NULL }
   };
 
   const char* statement_data[] = {
-    ",",
     "foo: 1, get foo() {}",
     "foo: 1, set foo(v) {}",
     "\"foo\": 1, get \"foo\"() {}",
     "\"foo\": 1, set \"foo\"(v) {}",
     "1: 1, get 1() {}",
-    "1: 1, set 1() {}",
-    // It's counter-intuitive, but these collide too (even in classic
-    // mode). Note that we can have "foo" and foo as properties in classic mode,
-    // but we cannot have "foo" and get foo, or foo and get "foo".
+    "1: 1, set 1(v) {}",
     "foo: 1, get \"foo\"() {}",
     "foo: 1, set \"foo\"(v) {}",
     "\"foo\": 1, get foo() {}",
     "\"foo\": 1, set foo(v) {}",
     "1: 1, get \"1\"() {}",
-    "1: 1, set \"1\"() {}",
-    "\"1\": 1, get 1() {}"
-    "\"1\": 1, set 1(v) {}"
+    "1: 1, set \"1\"(v) {}",
+    "\"1\": 1, get 1() {}",
+    "\"1\": 1, set 1(v) {}",
+    NULL
+  };
+
+  RunParserSyncTest(context_data, statement_data, kSuccess);
+}
+
+
+TEST(ErrorsObjectLiteralChecking) {
+  const char* context_data[][2] = {
+    {"\"use strict\"; var myobject = {", "};"},
+    {"var myobject = {", "};"},
+    { NULL, NULL }
+  };
+
+  const char* statement_data[] = {
+    // {,} is invalid
+    ",",
     // Wrong number of parameters
     "get bar(x) {}",
     "get bar(x, y) {}",
     "set bar() {}",
     "set bar(x, y) {}",
+    "set 1() {}",
+    "set \"1\"() {}",
     // Parsing FunctionLiteral for getter or setter fails
     "get foo( +",
     "get foo() \"error\"",
     NULL
   };
 
   RunParserSyncTest(context_data, statement_data, kError);
 }
 
 
@@ skipping 297 matching lines @@
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope scope(isolate);
   LocalContext env;
   i::FLAG_lazy = true;
   i::FLAG_min_preparse_length = 0;
   CompileRun("function this_is_lazy() {\n"
              "  break p;\n"
              "}\n"
              "this_is_lazy();\n");
 }