Relax object literal checking to follow ES6

src/x64/full-codegen-x64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_X64
 
 #include "src/code-stubs.h"
 #include "src/codegen.h"
@@ skipping 1640 matching lines @@
   for (int i = 0; i < expr->properties()->length(); i++) {
     ObjectLiteral::Property* property = expr->properties()->at(i);
     if (property->IsCompileTimeValue()) continue;
 
     Literal* key = property->key();
     Expression* value = property->value();
     if (!result_saved) {
       __ Push(rax);  // Save result on the stack
       result_saved = true;
     }
-    switch (property->kind()) {
-      case ObjectLiteral::Property::CONSTANT:
-        UNREACHABLE();
-      case ObjectLiteral::Property::MATERIALIZED_LITERAL:
-        ASSERT(!CompileTimeValue::IsCompileTimeValue(value));
-        // Fall through.
-      case ObjectLiteral::Property::COMPUTED:
-        if (key->value()->IsInternalizedString()) {
-          if (property->emit_store()) {
+    if (!property->emit_store()) {
+      VisitForEffect(value);
+    } else {
+      switch (property->kind()) {
+        case ObjectLiteral::Property::CONSTANT:
+          UNREACHABLE();
+        case ObjectLiteral::Property::MATERIALIZED_LITERAL:
+          ASSERT(!CompileTimeValue::IsCompileTimeValue(value));
+          // Fall through.
+        case ObjectLiteral::Property::COMPUTED:
+          if (key->value()->IsInternalizedString()) {
             VisitForAccumulatorValue(value);
             __ Move(rcx, key->value());
             __ movp(rdx, Operand(rsp, 0));
             CallStoreIC(key->LiteralFeedbackId());
             PrepareForBailoutForId(key->id(), NO_REGISTERS);
           } else {
-            VisitForEffect(value);
+            __ Push(Operand(rsp, 0));  // Duplicate receiver.
+            VisitForStackValue(key);
+            VisitForStackValue(value);
+            __ Push(Smi::FromInt(NONE));    // PropertyAttributes
+            __ CallRuntime(Runtime::kSetProperty, 4);
           }
           break;
-        }
-        __ Push(Operand(rsp, 0));  // Duplicate receiver.
-        VisitForStackValue(key);
-        VisitForStackValue(value);
-        if (property->emit_store()) {
-          __ Push(Smi::FromInt(NONE));    // PropertyAttributes
-          __ CallRuntime(Runtime::kSetProperty, 4);
-        } else {
-          __ Drop(3);
-        }
-        break;
-      case ObjectLiteral::Property::PROTOTYPE:
-        __ Push(Operand(rsp, 0));  // Duplicate receiver.
-        VisitForStackValue(value);
-        if (property->emit_store()) {
+        case ObjectLiteral::Property::PROTOTYPE:
+          __ Push(Operand(rsp, 0));  // Duplicate receiver.
+          VisitForStackValue(value);
           __ CallRuntime(Runtime::kSetPrototype, 2);
-        } else {
-          __ Drop(2);
-        }
-        break;
-      case ObjectLiteral::Property::GETTER:
-        accessor_table.lookup(key)->second->getter = value;
-        break;
-      case ObjectLiteral::Property::SETTER:
-        accessor_table.lookup(key)->second->setter = value;
-        break;
+          break;
+        case ObjectLiteral::Property::GETTER:
+          accessor_table.lookup(key)->second->getter = value;
+          break;
+        case ObjectLiteral::Property::SETTER:
+          accessor_table.lookup(key)->second->setter = value;
+          break;
+      }
     }
   }
 
   // Emit code to define accessors, using only a single call to the runtime for
   // each pair of corresponding getters and setters.
   for (AccessorTable::Iterator it = accessor_table.begin();
        it != accessor_table.end();
        ++it) {
     __ Push(Operand(rsp, 0));  // Duplicate receiver.
     VisitForStackValue(it->first);
@@ skipping 3089 matching lines @@
   ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
             Assembler::target_address_at(call_target_address,
                                          unoptimized_code));
   return OSR_AFTER_STACK_CHECK;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64