Source/bindings/scripts/idl_definitions.py - Issue 352133002: IDL: fix handling of non-decimal and unsigned default values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 352133002: IDL: fix handling of non-decimal and unsigned default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_definitions.py

diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py

index 896bd4320da7b92e596bf7f2dd5839350dda5e79..9a7509473b4bac75a8763cca5a58148db51411ef 100644

--- a/Source/bindings/scripts/idl_definitions.py

+++ b/Source/bindings/scripts/idl_definitions.py

@@ -450,7 +450,7 @@ def default_node_to_idl_literal(node):

raise ValueError('Unsupported string value: %r' % value)

return IdlLiteral(idl_type, value)

if idl_type == 'integer':

- return IdlLiteral(idl_type, int(node.GetProperty('NAME')))

+ return IdlLiteral(idl_type, int(node.GetProperty('NAME'), base=0))

if idl_type == 'float':

return IdlLiteral(idl_type, float(node.GetProperty('VALUE')))

if idl_type == 'boolean':

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »