Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 352113002: Remove deprecated RenderArena object and fix stack source path. (Closed)

Created:
6 years, 6 months ago by JungJik
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated RenderArena object and fix stack source path. RenderArena object is deprecated in WebCore. And WebCore path has been changed from WebCore to core. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282306

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M tools/deep_memory_profiler/policy.android.renderer.json View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tools/deep_memory_profiler/policy.android.webview.json View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tools/deep_memory_profiler/policy.l2.json View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tools/deep_memory_profiler/policy.sourcefile.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/deep_memory_profiler/sorter.malloc-component.json View 1 2 chunks +0 lines, -5 lines 0 comments Download
M tools/deep_memory_profiler/sorters/malloc.WebCore.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
JungJik
PTAL :)
6 years, 5 months ago (2014-07-10 01:44:58 UTC) #1
Dai Mikurube (NOT FULLTIME)
lgtm. Thanks!
6 years, 5 months ago (2014-07-10 04:14:04 UTC) #2
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-10 05:01:02 UTC) #3
JungJik
The CQ bit was unchecked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-10 05:01:05 UTC) #4
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-10 05:02:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/352113002/20001
6 years, 5 months ago (2014-07-10 05:03:11 UTC) #6
Dai Mikurube (NOT FULLTIME)
For changes under tools/deep_memory_profiler, you may want to specify NOTRY=True in the commit description. dmprof ...
6 years, 5 months ago (2014-07-10 05:25:50 UTC) #7
JungJik
On 2014/07/10 05:25:50, Dai Mikurube wrote: > For changes under tools/deep_memory_profiler, you may want to ...
6 years, 5 months ago (2014-07-10 06:29:14 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 11:08:26 UTC) #9
Message was sent while issue was closed.
Change committed as 282306

Powered by Google App Engine
This is Rietveld 408576698