Issue 352103002: Test that DevTools commands can be handled on worker thread when it is in a tight loop

Issue 352103002: Test that DevTools commands can be handled on worker thread when it is in a tight loop (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
keishi, sergeyv, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Test that DevTools commands can be handled on worker thread when it is in a tight loop The new test checks that when worker thread is blocked on a tight loop in JavaScript it can be interrupted to handle pending DevTools commands. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176916

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments, added missing file #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -24 lines)			Patch
A +	LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html	View	1	5 chunks	+21 lines, -24 lines	0 comments	Download
A	LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop-expected.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	LayoutTests/inspector-protocol/debugger/resources/dedicated-worker-loop.js	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

loislo

missing file https://codereview.chromium.org/352103002/diff/1/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html File LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html (right): https://codereview.chromium.org/352103002/diff/1/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html#newcode17 LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html:17: nuke this line https://codereview.chromium.org/352103002/diff/1/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html#newcode20 LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html:20: ditto

6 years, 6 months ago (2014-06-25 07:55:04 UTC) #2

yurys

https://codereview.chromium.org/352103002/diff/1/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html File LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html (right): https://codereview.chromium.org/352103002/diff/1/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html#newcode17 LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html:17: On 2014/06/25 07:55:04, loislo wrote: > nuke this line ...

6 years, 6 months ago (2014-06-25 07:56:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/352103002/20001

6 years, 6 months ago (2014-06-25 08:28:51 UTC) #6

Message was sent while issue was closed.

Change committed as 176916

Expand Messages | Collapse Messages