Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 352033002: Added --custom-launcher-page. Adds a page to the experimental launcher. (Closed)

Created:
6 years, 6 months ago by Matt Giuca
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, benwells, tapted
Project:
chromium
Visibility:
Public.

Description

Added --custom-launcher-page. Adds a page to the experimental launcher. This allows the user to specify a custom web page (which must be in the chrome-extension:// scheme) which will appear as a third top-level page in the experimental launcher, alongside the start and apps pages. This command-line switch is intended to be temporary; eventually, extensions will be able to specify their own custom launcher pages. For now, the command-line switch is sufficient for testing. Most of the Chrome APIs are not yet available for these pages. BUG=386004 TBR=mukai@chromium.org,jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279685

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do not load the custom launcher page unless IsExperimentalAppListEnabled. #

Patch Set 3 : Don't crash if the user supplies an invalid URL to --custom-launcher-page. #

Patch Set 4 : Fix Athena build. #

Patch Set 5 : Fix ash_shell build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M ash/shell/app_list.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M athena/home/app_list_view_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M athena/home/app_list_view_delegate.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 2 4 chunks +39 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Matt Giuca
So this is the launcher page working, and with the user able to specify their ...
6 years, 6 months ago (2014-06-25 04:58:35 UTC) #1
calamity
lgtm https://codereview.chromium.org/352033002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/352033002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode157 chrome/browser/ui/app_list/app_list_view_delegate.cc:157: if (command_line->HasSwitch(switches::kCustomLauncherPage)) { Worth making this do nothing ...
6 years, 6 months ago (2014-06-25 06:38:40 UTC) #2
Matt Giuca
https://codereview.chromium.org/352033002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/352033002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode157 chrome/browser/ui/app_list/app_list_view_delegate.cc:157: if (command_line->HasSwitch(switches::kCustomLauncherPage)) { On 2014/06/25 06:38:40, calamity wrote: > ...
6 years, 6 months ago (2014-06-25 07:21:43 UTC) #3
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 6 months ago (2014-06-25 07:21:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/352033002/40001
6 years, 6 months ago (2014-06-25 07:23:08 UTC) #5
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 6 months ago (2014-06-25 07:38:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/352033002/60001
6 years, 6 months ago (2014-06-25 07:39:39 UTC) #7
Matt Giuca
mukai: For rubber stamp on athena::AppListViewDelegate. (TBR should be appropriate.)
6 years, 6 months ago (2014-06-25 07:39:44 UTC) #8
Jun Mukai
athena lgtm
6 years, 6 months ago (2014-06-25 07:49:44 UTC) #9
Matt Giuca
Second time lucky! jamescook: Rubber stamp on ash ExampleAppListViewDelegate. (TBR should be OK).
6 years, 6 months ago (2014-06-25 08:01:28 UTC) #10
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 6 months ago (2014-06-25 08:01:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/352033002/80001
6 years, 6 months ago (2014-06-25 08:03:07 UTC) #12
commit-bot: I haz the power
Change committed as 279685
6 years, 6 months ago (2014-06-25 12:04:37 UTC) #13
James Cook
6 years, 6 months ago (2014-06-25 15:36:06 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698