Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 352013002: Revert 279557 "Support exposing Mojo services between render fra..." (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 279557 "Support exposing Mojo services between render fra..." Causing compile failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/60210 > Support exposing Mojo services between render frames, render threads, and their respective hosts. > > This introduces ServiceRegistry as an abstraction around providing > services to and accessing services from a remote peer. In particular, > this adds peered service registries to RenderProcessHost and > RenderThread, and to RenderFrameHost and RenderFrame - the RenderFrame > setup is implemented using the RenderProcessHost/RenderThread > ServiceRegistry pair. > > This replaces the existing WebUI handle setup by adding a webUI > controller service to the frame host registry and a corresponding > request for the webUI controller service to the frame registry. > > BUG=386155 > > Review URL: https://codereview.chromium.org/285333003 TBR=sammc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -472 lines) Patch
M trunk/src/chrome/browser/ui/webui/mojo_web_ui_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/mojo_web_ui_controller.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/test/base/run_all_unittests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/content/browser/mojo/mojo_application_host.h View 2 chunks +25 lines, -7 lines 0 comments Download
MM trunk/src/content/browser/mojo/mojo_application_host.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.h View 4 chunks +15 lines, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M trunk/src/content/browser/webui/web_ui_mojo_browsertest.cc View 3 chunks +4 lines, -26 lines 0 comments Download
M trunk/src/content/child/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/child_thread.h View 5 chunks +13 lines, -6 lines 0 comments Download
M trunk/src/content/child/child_thread.cc View 2 chunks +10 lines, -1 line 0 comments Download
M trunk/src/content/child/mojo/mojo_application.h View 2 chunks +12 lines, -7 lines 0 comments Download
M trunk/src/content/child/mojo/mojo_application.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M trunk/src/content/common/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
A + trunk/src/content/common/mojo/mojo_service_names.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/common/mojo/mojo_service_names.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/content/common/mojo/service_registry_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D trunk/src/content/common/mojo/service_registry_impl.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D trunk/src/content/common/render_frame_setup.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
A + trunk/src/content/common/web_ui_setup.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/content_common.gypi View 3 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/content/content_common_mojo_bindings.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/ppapi_plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/browser/render_frame_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/browser/render_process_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/browser/render_view_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
D trunk/src/content/public/common/service_registry.h View 1 chunk +0 lines, -73 lines 0 comments Download
M trunk/src/content/public/renderer/render_frame.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/renderer/render_thread.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/test/mock_render_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/test/mock_render_process_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/test/mock_render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/test/mock_render_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/render_frame_impl.h View 4 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/render_frame_impl.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.h View 4 chunks +7 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.cc View 8 chunks +15 lines, -60 lines 0 comments Download
M trunk/src/content/renderer/web_ui_mojo.cc View 2 chunks +2 lines, -6 lines 0 comments Download
A + trunk/src/content/renderer/web_ui_setup_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/renderer/web_ui_setup_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/worker/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
xhwang
6 years, 6 months ago (2014-06-25 00:39:47 UTC) #1
xhwang
6 years, 6 months ago (2014-06-25 00:40:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r279561 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698