Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 3520018: Merge 69148 - [V8] Add FileReader to active DOM map... (Closed)

Created:
9 years, 6 months ago by jianli
Modified:
8 years, 9 months ago
Reviewers:
jianli
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 69148 - [V8] Add FileReader to active DOM map https://bugs.webkit.org/show_bug.cgi?id=47205 Reviewed by Nate Chapin. We need to have a custom FileReader V8 constructor in order to add object into active DOM map to prevent it from GC-ed when it is still in-use. * Android.v8bindings.mk: * WebCore.gypi: * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/custom/V8FileReaderCustom.cpp: Added. (WebCore::V8FileReader::constructorCallback): * fileapi/FileReader.idl: TBR=jianli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M WebCore/Android.v8bindings.mk View 1 chunk +1 line, -0 lines 0 comments Download
M WebCore/WebCore.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M WebCore/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -0 lines 0 comments Download
A + WebCore/bindings/v8/custom/V8FileReaderCustom.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/fileapi/FileReader.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jianli
9 years, 6 months ago (2010-10-05 23:00:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698