Issue 351973004: Add some RenderObject unit tests

Issue 351973004: Add some RenderObject unit tests (Closed)

Created:
6 years, 6 months ago by Julien - ping for review

Modified:
5 years ago

Reviewers:
leviw_travelin_and_unemployed, chrishtr, esprehn, ojan

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add some RenderObject unit tests This change is an exploratory patch into adding some kind of unit testing to rendering/. It relies on DummyPageHolder and setInnerHTML so they are not very low-level unit tests but they allow us to drill more into the RenderObjects.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Improved version after the review comments. #

Patch Set 3 : Even better change. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -0 lines)			Patch
	M	Source/core/core.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	Source/core/rendering/RenderObjectTest.cpp	View	1 2	1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

This is an exploratory patches but it shows what we could do with unit test-ish.

6 years, 5 months ago (2014-06-26 17:21:46 UTC) #1

esprehn

This seems like a reasonable approach to me if others are okay with it.

6 years, 5 months ago (2014-06-26 21:06:28 UTC) #2

leviw_travelin_and_unemployed

Oh man... I could think of some great anonymous renderer creation tests that could be ...

6 years, 5 months ago (2014-06-26 21:39:02 UTC) #3

chrishtr

https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp File Source/core/rendering/RenderObjectTest.cpp (right): https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp#newcode2 Source/core/rendering/RenderObjectTest.cpp:2: * Copyright (C) 2014 Google Inc. All rights reserved. ...

6 years, 5 months ago (2014-06-27 00:49:31 UTC) #4

esprehn

https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp File Source/core/rendering/RenderObjectTest.cpp (right): https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp#newcode68 Source/core/rendering/RenderObjectTest.cpp:68: setHtmlInnerHTML("<html><body><div style='display:none'></div></body></html>"); This is not right, since you innerHTML ...

6 years, 5 months ago (2014-06-27 08:15:34 UTC) #5

Julien - ping for review

Update change for the taker. https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp File Source/core/rendering/RenderObjectTest.cpp (right): https://codereview.chromium.org/351973004/diff/1/Source/core/rendering/RenderObjectTest.cpp#newcode2 Source/core/rendering/RenderObjectTest.cpp:2: * Copyright (C) 2014 ...

6 years, 5 months ago (2014-06-29 02:01:39 UTC) #6

Julien - ping for review

5 years ago (2015-12-07 23:28:51 UTC) #7

The skeleton for unit testing was landed at some point. Closing this review as
it has rot. I will land the tests separately now that it's not controversial.

Expand Messages | Collapse Messages