Issue 351963003: [NaCl SDK] Simplify httpd.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351963003: [NaCl SDK] Simplify httpd.py (Closed)

Created:
6 years, 6 months ago by binji

Modified:
6 years, 6 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Simplify httpd.py There was a lot of code for handling example-specific delegates, but we don't need it anymore and it complicates the HTTP server. I've removed it. In addition, there was a bug in the delegate search that would cause an infinite loop, so this is actually fixing a real bug too. BUG=none R=sbc@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -128 lines)			Patch
M	native_client_sdk/src/tools/httpd.py	View	8 chunks	+7 lines, -106 lines	0 comments	Download
M	native_client_sdk/src/tools/run.py	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	native_client_sdk/src/tools/tests/httpd_test.py	View	3 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages