Chromium Code Reviews

Issue 351943004: Add PROJECT to tools (Closed)

Created:
6 years, 6 months ago by sheyang
Modified:
3 years, 10 months ago
Reviewers:
chase, cmp, jam, M-A Ruel, johnmarienettal, Paweł Hajdan Jr., agable
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+7 lines, -0 lines)
M build/codereview.settings View 1 chunk +1 line, -0 lines 0 comments
M chrome-devtools-frontend/codereview.settings View 1 chunk +1 line, -0 lines 0 comments
M codereview.settings View 1 chunk +1 line, -0 lines 0 comments
M depot_tools/codereview.settings View 1 chunk +1 line, -0 lines 0 comments
M deps2git/codereview.settings View 1 chunk +1 line, -0 lines 0 comments
M perf/codereview.settings View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 12 (1 generated)
sheyang
6 years, 6 months ago (2014-06-24 18:48:58 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-25 19:18:42 UTC) #2
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-25 20:51:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/351943004/1
6 years, 6 months ago (2014-06-25 20:52:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 20:55:24 UTC) #5
commit-bot: I haz the power
Presubmit check for 351943004-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-25 20:55:25 UTC) #6
sheyang
Adding jam@ to reviews changes in chrome-devtools-frontend/codereview.settings. Adding maruel@ to review changes in codereview.settings and ...
6 years, 6 months ago (2014-06-25 22:34:59 UTC) #7
sheyang
Adding jam@ to reviews changes in chrome-devtools-frontend/codereview.settings. Adding maruel@ to review changes in codereview.settings and ...
6 years, 6 months ago (2014-06-25 22:37:06 UTC) #8
cmp
On 2014/06/25 22:37:06, sheyang wrote: > Adding jam@ to reviews changes in chrome-devtools-frontend/codereview.settings. > > ...
6 years, 6 months ago (2014-06-25 22:47:00 UTC) #9
sheyang
Committed patchset #1 manually as r279843.
6 years, 6 months ago (2014-06-25 22:52:34 UTC) #10
johnmarienettal
3 years, 10 months ago (2017-02-23 14:03:28 UTC) #12
Message was sent while issue was closed.

          

Powered by Google App Engine