Refactoring activity logger.

Enables logger to log changes to certain elements and attributes.

BUG=388287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177289

[pmarch, 2014-06-27 15:05:53]

Hi Kentaro and Pavel 

Could you please look into this CL.

Thanks

[haraken, 2014-06-27 15:18:08]

+esprehn

Would you just check if this change doesn't regress performance of
Dromaeo/dom-attr?

https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.h (right):

https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.h:88: virtual void attributeWillChange(const
QualifiedName&, const AtomicString&, const AtomicString&) OVERRIDE;

We normally add variable names to a method declaration when we have multiple
variables of the same type.

https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
File Source/web/tests/ActivityLoggerTest.cpp (right):

https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
Source/web/tests/ActivityLoggerTest.cpp:306: v8::HandleScope
scope(v8::Isolate::GetCurrent());

I think you can add a HandleScope in executeScriptInMainWorld and
executeScriptInIsolatedWorld instead of adding the HandleScope to each test.

[pmarch, 2014-06-27 16:55:45]

https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.h (right):

https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.h:88: virtual void attributeWillChange(const
QualifiedName&, const AtomicString&, const AtomicString&) OVERRIDE;
On 2014/06/27 15:18:08, haraken wrote:
> 
> We normally add variable names to a method declaration when we have multiple
> variables of the same type.

Done.

https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
File Source/web/tests/ActivityLoggerTest.cpp (right):

https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
Source/web/tests/ActivityLoggerTest.cpp:306: v8::HandleScope
scope(v8::Isolate::GetCurrent());
On 2014/06/27 15:18:08, haraken wrote:
> 
> I think you can add a HandleScope in executeScriptInMainWorld and
> executeScriptInIsolatedWorld instead of adding the HandleScope to each test.

Done.

[pmarch, 2014-06-27 16:57:42]

On 2014/06/27 15:18:08, haraken wrote:
> +esprehn
> 
> Would you just check if this change doesn't regress performance of
> Dromaeo/dom-attr?

No regression

The first two is vanilla, the last two is CL

/Dromaeo/dom-attr:Runs	runs/s	114.18	± 0.77%	110.24	± 3.27%	3.45% Worse
	111.08	± 0.47%	2.72% Worse 	111.07	± 0.66%	2.72% Worse 

>
https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
> File Source/core/html/HTMLAnchorElement.h (right):
> 
>
https://codereview.chromium.org/351923005/diff/1/Source/core/html/HTMLAnchorE...
> Source/core/html/HTMLAnchorElement.h:88: virtual void
attributeWillChange(const
> QualifiedName&, const AtomicString&, const AtomicString&) OVERRIDE;
> 
> We normally add variable names to a method declaration when we have multiple
> variables of the same type.
> 
>
https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
> File Source/web/tests/ActivityLoggerTest.cpp (right):
> 
>
https://codereview.chromium.org/351923005/diff/1/Source/web/tests/ActivityLog...
> Source/web/tests/ActivityLoggerTest.cpp:306: v8::HandleScope
> scope(v8::Isolate::GetCurrent());
> 
> I think you can add a HandleScope in executeScriptInMainWorld and
> executeScriptInIsolatedWorld instead of adding the HandleScope to each test.

[haraken, 2014-06-28 00:09:05]

LGTM

[pmarch, 2014-06-29 20:38:20]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-29 20:38:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/20001

[commit-bot: I haz the power, 2014-06-29 21:25:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8851)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13480)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14475)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22992)

[commit-bot: I haz the power, 2014-06-29 21:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-29 21:27:17]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22997)

[pmarch, 2014-06-30 09:02:04]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-30 09:02:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/40001

[pmarch, 2014-06-30 09:09:08]

The CQ bit was unchecked by pmarch@chromium.org

[pmarch, 2014-06-30 09:29:05]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-30 09:29:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/60001

[pmarch, 2014-06-30 09:52:09]

The CQ bit was unchecked by pmarch@chromium.org

[pmarch, 2014-06-30 10:09:29]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-30 10:10:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/80001

[pmarch, 2014-06-30 10:26:53]

The CQ bit was unchecked by pmarch@chromium.org

[pmarch, 2014-07-01 09:21:41]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-07-01 09:22:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/100001

[pmarch, 2014-07-01 09:24:15]

The CQ bit was unchecked by pmarch@chromium.org

[pfeldman, 2014-07-01 09:27:45]

web/ rslgtm

[pmarch, 2014-07-01 09:28:04]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-07-01 09:28:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/351923005/100001

[commit-bot: I haz the power, 2014-07-01 10:31:49]

Change committed as 177289

[eseidel, 2014-07-01 19:50:59]

A revert of this CL has been created in
https://codereview.chromium.org/362073004/ by eseidel@chromium.org.

The reason for reverting is: This appears to have added a flaky test which
caused the Bilnk roll to get reverted:

http://src.chromium.org/viewvc/chrome?view=rev&revision=280864.

[pmarch, 2014-07-01 20:31:51]

On 2014/07/01 19:50:59, eseidel wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/362073004/ by mailto:eseidel@chromium.org.
> 
> The reason for reverting is: This appears to have added a flaky test which
> caused the Bilnk roll to get reverted:
> 
> http://src.chromium.org/viewvc/chrome?view=rev&revision=280864.

I will disable tests instead reverting this CL and investigate the issue.

[pmarch, 2014-07-01 20:48:55]

On 2014/07/01 20:31:51, pmarch wrote:
> On 2014/07/01 19:50:59, eseidel wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/362073004/ by mailto:eseidel@chromium.org.
> > 
> > The reason for reverting is: This appears to have added a flaky test which
> > caused the Bilnk roll to get reverted:
> > 
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=280864.
> 
> I will disable tests instead reverting this CL and investigate the issue.

CL https://codereview.chromium.org/366723002/ to disable the flaky test.