Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2240)

Unified Diff: Source/devtools/front_end/sources/BreakpointsSidebarPane.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/LayerTreeModel.js ('k') | Source/devtools/front_end/timeline/Layers3DView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sources/BreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/sources/BreakpointsSidebarPane.js b/Source/devtools/front_end/sources/BreakpointsSidebarPane.js
index ab6b8b18a74fb5998907077a0f77dd8379a198e4..414116369124e59baabe6d57922573d3b9f1b8fb 100644
--- a/Source/devtools/front_end/sources/BreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/sources/BreakpointsSidebarPane.js
@@ -327,7 +327,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
inputElement.className = "editing";
inputElement.id = "breakpoint-condition-input";
inputElementContainer.appendChild(inputElement);
- this._addListElement(inputElementContainer, this.listElement.firstChild);
+ this.addListElement(inputElementContainer, /** @type {?Element} */ (this.listElement.firstChild));
/**
* @param {boolean} accept
@@ -337,7 +337,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
*/
function finishEditing(accept, e, text)
{
- this._removeListElement(inputElementContainer);
+ this.removeListElement(inputElementContainer);
if (accept) {
this._setBreakpoint(text, true);
this._saveBreakpoints();
@@ -374,13 +374,13 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
labelElement.addEventListener("dblclick", this._labelClicked.bind(this, url), false);
element.appendChild(labelElement);
- var currentElement = this.listElement.firstChild;
+ var currentElement = /** @type {?Element} */ (this.listElement.firstChild);
while (currentElement) {
if (currentElement._url && currentElement._url < element._url)
break;
- currentElement = currentElement.nextSibling;
+ currentElement = /** @type {?Element} */ (currentElement.nextSibling);
}
- this._addListElement(element, currentElement);
+ this.addListElement(element, currentElement);
this._breakpointElements[url] = element;
if (enabled)
DOMDebuggerAgent.setXHRBreakpoint(url);
@@ -392,7 +392,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
if (!element)
return;
- this._removeListElement(element);
+ this.removeListElement(element);
delete this._breakpointElements[url];
if (element._checkboxElement.checked)
DOMDebuggerAgent.removeXHRBreakpoint(url);
@@ -454,7 +454,7 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
*/
function finishEditing(accept, e, text)
{
- this._removeListElement(inputElement);
+ this.removeListElement(inputElement);
if (accept) {
this._removeBreakpoint(url);
this._setBreakpoint(text, element._checkboxElement.checked);
« no previous file with comments | « Source/devtools/front_end/sdk/LayerTreeModel.js ('k') | Source/devtools/front_end/timeline/Layers3DView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698