DevTools: Avoid private member access in non-profiler code

Source/devtools/front_end/ui/View.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 49 matching lines @@
     var styleElement = document.createElement("style");
     styleElement.type = "text/css";
     styleElement.textContent = loadResource(cssFile) + WebInspector.View._buildSourceURL(cssFile);
     document.head.insertBefore(styleElement, document.head.firstChild);
     return styleElement;
 }
 
 WebInspector.View.prototype = {
     markAsRoot: function()
     {
-        WebInspector.View._assert(!this.element.parentElement, "Attempt to mark as root attached node");
+        WebInspector.View.__assert(!this.element.parentElement, "Attempt to mark as root attached node");
         this._isRoot = true;
     },
 
     /**
      * @return {?WebInspector.View}
      */
     parentView: function()
     {
         return this._parentView;
     },
@@ skipping 117 matching lines @@
     onLayout: function()
     {
     },
 
     /**
      * @param {?Element} parentElement
      * @param {?Element=} insertBefore
      */
     show: function(parentElement, insertBefore)
     {
-        WebInspector.View._assert(parentElement, "Attempt to attach view with no parent element");
+        WebInspector.View.__assert(parentElement, "Attempt to attach view with no parent element");
 
         // Update view hierarchy
         if (this.element.parentElement !== parentElement) {
             if (this.element.parentElement)
                 this.detach();
 
             var currentParent = parentElement;
             while (currentParent && !currentParent.__view)
                 currentParent = currentParent.parentElement;
 
             if (currentParent) {
                 this._parentView = currentParent.__view;
                 this._parentView._children.push(this);
                 this._isRoot = false;
             } else
-                WebInspector.View._assert(this._isRoot, "Attempt to attach view to orphan node");
+                WebInspector.View.__assert(this._isRoot, "Attempt to attach view to orphan node");
         } else if (this._visible) {
             return;
         }
 
         this._visible = true;
 
         if (this._parentIsShowing())
             this._processWillShow();
 
         this.element.classList.add("visible");
@@ skipping 42 matching lines @@
         WebInspector.View._decrementViewCounter(parentElement, this.element);
         WebInspector.View._originalRemoveChild.call(parentElement, this.element);
 
         this._visible = false;
         if (this._parentIsShowing())
             this._processWasHidden();
 
         // Update view hierarchy
         if (this._parentView) {
             var childIndex = this._parentView._children.indexOf(this);
-            WebInspector.View._assert(childIndex >= 0, "Attempt to remove non-child view");
+            WebInspector.View.__assert(childIndex >= 0, "Attempt to remove non-child view");
             this._parentView._children.splice(childIndex, 1);
             var parent = this._parentView;
             this._parentView = null;
             if (this._hasNonZeroConstraints())
                 parent.invalidateConstraints();
         } else
-            WebInspector.View._assert(this._isRoot, "Removing non-root view from DOM");
+            WebInspector.View.__assert(this._isRoot, "Removing non-root view from DOM");
     },
 
     detachChildViews: function()
     {
         var children = this._children.slice();
         for (var i = 0; i < children.length; ++i)
             children[i].detach();
     },
 
     /**
@@ skipping 250 matching lines @@
     var count = (childElement.__viewCounter || 0) + (childElement.__view ? 1 : 0);
     if (!count)
         return;
 
     while (parentElement) {
         parentElement.__viewCounter -= count;
         parentElement = parentElement.parentElement;
     }
 }
 
-WebInspector.View._assert = function(condition, message)
+WebInspector.View.__assert = function(condition, message)
 {
     if (!condition) {
         console.trace();
         throw new Error(message);
     }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.View}
@@ skipping 86 matching lines @@
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @param {?Node} child
  * @return {?Node}
  * @suppress {duplicate}
  */
 Element.prototype.appendChild = function(child)
 {
-    WebInspector.View._assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
+    WebInspector.View.__assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
     return WebInspector.View._originalAppendChild.call(this, child);
 }
 
 /**
  * @param {?Node} child
  * @param {?Node} anchor
  * @return {!Node}
  * @suppress {duplicate}
  */
 Element.prototype.insertBefore = function(child, anchor)
 {
-    WebInspector.View._assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
+    WebInspector.View.__assert(!child.__view || child.parentElement === this, "Attempt to add view via regular DOM operation.");
     return WebInspector.View._originalInsertBefore.call(this, child, anchor);
 }
 
 /**
  * @param {?Node} child
  * @return {!Node}
  * @suppress {duplicate}
  */
 Element.prototype.removeChild = function(child)
 {
-    WebInspector.View._assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
+    WebInspector.View.__assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
     return WebInspector.View._originalRemoveChild.call(this, child);
 }
 
 Element.prototype.removeChildren = function()
 {
-    WebInspector.View._assert(!this.__viewCounter, "Attempt to remove element containing view via regular DOM operation");
+    WebInspector.View.__assert(!this.__viewCounter, "Attempt to remove element containing view via regular DOM operation");
     WebInspector.View._originalRemoveChildren.call(this);
 }