Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TracingTimelineUIUtils = function() 9 WebInspector.TracingTimelineUIUtils = function()
10 { 10 {
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 case recordType.FunctionCall: 339 case recordType.FunctionCall:
340 details = linkifyLocation(eventData["scriptId"], eventData["scriptName"] , eventData["scriptLine"], 0); 340 details = linkifyLocation(eventData["scriptId"], eventData["scriptName"] , eventData["scriptLine"], 0);
341 break; 341 break;
342 case recordType.FireAnimationFrame: 342 case recordType.FireAnimationFrame:
343 detailsText = eventData["id"]; 343 detailsText = eventData["id"];
344 break; 344 break;
345 case recordType.EventDispatch: 345 case recordType.EventDispatch:
346 detailsText = eventData ? eventData["type"] : null; 346 detailsText = eventData ? eventData["type"] : null;
347 break; 347 break;
348 case recordType.Paint: 348 case recordType.Paint:
349 var width = WebInspector.TimelineUIUtils._quadWidth(eventData.clip); 349 var width = WebInspector.TimelineUIUtils.quadWidth(eventData.clip);
350 var height = WebInspector.TimelineUIUtils._quadHeight(eventData.clip); 350 var height = WebInspector.TimelineUIUtils.quadHeight(eventData.clip);
351 if (width && height) 351 if (width && height)
352 detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height); 352 detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height);
353 break; 353 break;
354 case recordType.TimerInstall: 354 case recordType.TimerInstall:
355 case recordType.TimerRemove: 355 case recordType.TimerRemove:
356 details = linkifyTopCallFrame(); 356 details = linkifyTopCallFrame();
357 detailsText = eventData["timerId"]; 357 detailsText = eventData["timerId"];
358 break; 358 break;
359 case recordType.RequestAnimationFrame: 359 case recordType.RequestAnimationFrame:
360 case recordType.CancelAnimationFrame: 360 case recordType.CancelAnimationFrame:
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 * @param {!WebInspector.Target} target 471 * @param {!WebInspector.Target} target
472 */ 472 */
473 WebInspector.TracingTimelineUIUtils.buildTraceEventDetails = function(event, mod el, linkifier, callback, loadedFromFile, target) 473 WebInspector.TracingTimelineUIUtils.buildTraceEventDetails = function(event, mod el, linkifier, callback, loadedFromFile, target)
474 { 474 {
475 var relatedNode = null; 475 var relatedNode = null;
476 var barrier = new CallbackBarrier(); 476 var barrier = new CallbackBarrier();
477 if (!event.previewElement) { 477 if (!event.previewElement) {
478 if (event.imageURL) 478 if (event.imageURL)
479 WebInspector.DOMPresentationUtils.buildImagePreviewContents(target, event.imageURL, false, barrier.createCallback(saveImage)); 479 WebInspector.DOMPresentationUtils.buildImagePreviewContents(target, event.imageURL, false, barrier.createCallback(saveImage));
480 else if (event.picture) 480 else if (event.picture)
481 WebInspector.TracingTimelineUIUtils._buildPicturePreviewContent(even t.picture, barrier.createCallback(saveImage)); 481 WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(event .picture, barrier.createCallback(saveImage));
482 } 482 }
483 if (event.backendNodeId) 483 if (event.backendNodeId)
484 target.domModel.pushNodesByBackendIdsToFrontend([event.backendNodeId], b arrier.createCallback(setRelatedNode)); 484 target.domModel.pushNodesByBackendIdsToFrontend([event.backendNodeId], b arrier.createCallback(setRelatedNode));
485 barrier.callWhenDone(callbackWrapper); 485 barrier.callWhenDone(callbackWrapper);
486 486
487 /** 487 /**
488 * @param {!Element=} element 488 * @param {!Element=} element
489 */ 489 */
490 function saveImage(element) 490 function saveImage(element)
491 { 491 {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 contentHelper.appendTextRow(WebInspector.UIString("Encoded Data Leng th"), WebInspector.UIString("%d Bytes", eventData["encodedDataLength"])); 581 contentHelper.appendTextRow(WebInspector.UIString("Encoded Data Leng th"), WebInspector.UIString("%d Bytes", eventData["encodedDataLength"]));
582 break; 582 break;
583 case recordTypes.EvaluateScript: 583 case recordTypes.EvaluateScript:
584 var url = eventData["url"]; 584 var url = eventData["url"];
585 if (url) 585 if (url)
586 contentHelper.appendLocationRow(WebInspector.UIString("Script"), url , eventData["lineNumber"]); 586 contentHelper.appendLocationRow(WebInspector.UIString("Script"), url , eventData["lineNumber"]);
587 break; 587 break;
588 case recordTypes.Paint: 588 case recordTypes.Paint:
589 var clip = eventData["clip"]; 589 var clip = eventData["clip"];
590 contentHelper.appendTextRow(WebInspector.UIString("Location"), WebInspec tor.UIString("(%d, %d)", clip[0], clip[1])); 590 contentHelper.appendTextRow(WebInspector.UIString("Location"), WebInspec tor.UIString("(%d, %d)", clip[0], clip[1]));
591 var clipWidth = WebInspector.TimelineUIUtils._quadWidth(clip); 591 var clipWidth = WebInspector.TimelineUIUtils.quadWidth(clip);
592 var clipHeight = WebInspector.TimelineUIUtils._quadHeight(clip); 592 var clipHeight = WebInspector.TimelineUIUtils.quadHeight(clip);
593 contentHelper.appendTextRow(WebInspector.UIString("Dimensions"), WebInsp ector.UIString("%d × %d", clipWidth, clipHeight)); 593 contentHelper.appendTextRow(WebInspector.UIString("Dimensions"), WebInsp ector.UIString("%d × %d", clipWidth, clipHeight));
594 // Fall-through intended. 594 // Fall-through intended.
595 595
596 case recordTypes.PaintSetup: 596 case recordTypes.PaintSetup:
597 case recordTypes.Rasterize: 597 case recordTypes.Rasterize:
598 case recordTypes.ScrollLayer: 598 case recordTypes.ScrollLayer:
599 relatedNodeLabel = WebInspector.UIString("Layer root"); 599 relatedNodeLabel = WebInspector.UIString("Layer root");
600 break; 600 break;
601 case recordTypes.PaintImage: 601 case recordTypes.PaintImage:
602 case recordTypes.DecodeLazyPixelRef: 602 case recordTypes.DecodeLazyPixelRef:
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 total[category] = (total[category] || 0) + nextEvent.selfTime; 707 total[category] = (total[category] || 0) + nextEvent.selfTime;
708 } 708 }
709 } 709 }
710 return hasChildren; 710 return hasChildren;
711 } 711 }
712 712
713 /** 713 /**
714 * @param {string} encodedPicture 714 * @param {string} encodedPicture
715 * @param {function(!Element=)} callback 715 * @param {function(!Element=)} callback
716 */ 716 */
717 WebInspector.TracingTimelineUIUtils._buildPicturePreviewContent = function(encod edPicture, callback) 717 WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent = function(encode dPicture, callback)
718 { 718 {
719 var snapshotId; 719 var snapshotId;
720 720
721 LayerTreeAgent.loadSnapshot(encodedPicture, onSnapshotLoaded); 721 LayerTreeAgent.loadSnapshot(encodedPicture, onSnapshotLoaded);
722 /** 722 /**
723 * @param {string} error 723 * @param {string} error
724 * @param {string} id 724 * @param {string} id
725 */ 725 */
726 function onSnapshotLoaded(error, id) 726 function onSnapshotLoaded(error, id)
727 { 727 {
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 else if (recordType === recordTypes.TimeStamp) 774 else if (recordType === recordTypes.TimeStamp)
775 eventDivider.className += " resources-orange-divider"; 775 eventDivider.className += " resources-orange-divider";
776 else if (recordType === recordTypes.BeginFrame) 776 else if (recordType === recordTypes.BeginFrame)
777 eventDivider.className += " timeline-frame-divider"; 777 eventDivider.className += " timeline-frame-divider";
778 778
779 if (title) 779 if (title)
780 eventDivider.title = title; 780 eventDivider.title = title;
781 781
782 return eventDivider; 782 return eventDivider;
783 } 783 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('k') | Source/devtools/front_end/timeline/TransformController.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698